expand scope of validation test and check validation

Author: theFong

.github/workflows/validation-lambdalabs.yml

@@ -9,6 +9,7 @@ on:
   pull_request:
     paths:
       - 'internal/lambdalabs/**'
+      - 'pkg/v1/**'
     branches: [ main ]
 
 jobs:
@@ -43,6 +44,7 @@ jobs:
         LAMBDALABS_API_KEY: ${{ secrets.LAMBDALABS_API_KEY }}
         TEST_PRIVATE_KEY_BASE64: ${{ secrets.TEST_PRIVATE_KEY_BASE64 }}
         TEST_PUBLIC_KEY_BASE64: ${{ secrets.TEST_PUBLIC_KEY_BASE64 }}
+        VALIDATION_TEST: true
       run: |
         cd internal/lambdalabs
         go test -v -short=false -timeout=30m ./...

internal/lambdalabs/v1/validation_test.go

@@ -9,10 +9,8 @@ import (
 )
 
 func TestValidationFunctions(t *testing.T) {
-	apiKey := os.Getenv("LAMBDALABS_API_KEY")
-	if apiKey == "" {
-		t.Skip("LAMBDALABS_API_KEY not set, skipping LambdaLabs validation tests")
-	}
+	checkSkip(t)
+	apiKey := getAPIKey()
 
 	config := validation.ProviderConfig{
 		Credential: NewLambdaLabsCredential("validation-test", apiKey),
@@ -23,14 +21,26 @@ func TestValidationFunctions(t *testing.T) {
 }
 
 func TestInstanceLifecycleValidation(t *testing.T) {
-	apiKey := os.Getenv("LAMBDALABS_API_KEY")
-	if apiKey == "" {
-		t.Skip("LAMBDALABS_API_KEY not set, skipping LambdaLabs validation tests")
-	}
+	checkSkip(t)
+	apiKey := getAPIKey()
 
 	config := validation.ProviderConfig{
 		Credential: NewLambdaLabsCredential("validation-test", apiKey),
 	}
 
 	validation.RunInstanceLifecycleValidation(t, config)
 }
+
+func checkSkip(t *testing.T) {
+	apiKey := getAPIKey()
+	isValidationTest := os.Getenv("VALIDATION_TEST")
+	if apiKey == "" && isValidationTest != "" {
+		t.Fatal("LAMBDALABS_API_KEY not set, but VALIDATION_TEST is set")
+	} else if apiKey == "" && isValidationTest == "" {
+		t.Skip("LAMBDALABS_API_KEY not set, skipping LambdaLabs validation tests")
+	}
+}
+
+func getAPIKey() string {
+	return os.Getenv("LAMBDALABS_API_KEY")
+}