Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(wallet): Recently Interacted Address History #27116

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Douglashdaniel
Copy link
Contributor

@Douglashdaniel Douglashdaniel commented Jan 3, 2025

Description

Introduces a Recent addresses feature in the Wallet Send flow.

  • The Send screen will now keep a history for the user to see Recent addresses they have sent to for quick access to new transactions.
  • The user will have the ability to delete an address from their history with a Trash button.
  • No more then 5 addresses will be kept in history at a time for each chainId/CoinType
  • If a user sends to one of their own addresses in the Wallet, that address will not be stored in history.

Resolves brave/brave-browser#43095
Security Review https://github.com/brave/reviews/issues/1837

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Screenshot 10

@Douglashdaniel Douglashdaniel self-assigned this Jan 3, 2025
@Douglashdaniel Douglashdaniel requested review from a team as code owners January 3, 2025 21:34
@github-actions github-actions bot added CI/storybook-url Deploy storybook and provide a unique URL for each build feature/web3/wallet feature/web3/wallet/core labels Jan 3, 2025
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Recently Interacted Addresses history for Send
2 participants