Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no need to generate png thumbnail from this app #7

Open
soichih opened this issue Apr 22, 2021 · 1 comment
Open

no need to generate png thumbnail from this app #7

soichih opened this issue Apr 22, 2021 · 1 comment

Comments

@soichih
Copy link
Contributor

soichih commented Apr 22, 2021

This app currently generates thumbnail png and store it to product.json. Now that we have validators doing the thumbnail generation, we don't need to do this for each App. In fact, I suggest to remove it as it is redundant to show the thumbnail.

image

@francopestilli
Copy link
Contributor

this sounds right to me. We can eliminate the thumbnail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants