[Suggestion]: Make discord-presence optional

[Bqleine]

Is your suggestion related to a problem? Please describe.
Discord is non-free software, and it is too bad that an unrelated free software would try to interact with it, while I understand the fun intent I would enjoy it remaining optional.

Describe the solution you'd like
I would like the discord-presence dependency to be made optional, possibly under a cargo feature.

Describe alternatives you've considered
Patching the source to remove the dependency.

• This suggestion is compatible with the GNOME Human Interface Guidelines

---

I’m open to making a pull request for this, if you agree with the suggestion.

[bragefuglseth]

Hi, and thanks for voicing your concern. I’ve been thinking about something like this too, but for a different reason, which is that the current implementation of the Discord integration requires Keypunch to poke a persistent hole in the Flatpak sandbox. This results in e.g. Flathub and GNOME Software downgrading our safety rating (and rightly so). It’s not a good look in terms of neither privacy nor security.

What we’ll end up with is likely a solution where the Discord integration has to be manually enabled in the app by "opening" Discord’s system folder in a one-time setup process, thus granting Keypunch sandboxed access to it in a transparent manner. Doing this is of course going to be optional and revokable; after all Keypunch works just fine without it.

I’m not really interested in making the discord-presence dependency optional, though, as it would unnecessarily complicate the codebase with minimal to no gains from my perspective. It’s also worth noting that discord-presence is fully open and licensed under the MIT license; I would never ship proprietary software in Keypunch itself to enable this.