Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Loading an Excel file into Model repeats many operations #6

Open
bradbase opened this issue May 18, 2020 · 0 comments
Open

Loading an Excel file into Model repeats many operations #6

bradbase opened this issue May 18, 2020 · 0 comments
Labels
bug Something isn't working

Comments

@bradbase
Copy link
Owner

While loading an Excel file in to the xlcalculator Model object there are operations which repeat a lot so one or more things are in loops which probably don't need to be. This is making file loading inefficient.

Fixing this will make file loading significantly more efficient.
@bradbase bradbase added the bug Something isn't working label May 18, 2020
bradbase added a commit that referenced this issue May 21, 2020
@Brad-eki @bradbase
Addressing Bugs #3, #6, #9 and #10
2ae8c45 
re-setting cellparts after each cell in reader.py addressing bug #10
changed replace to strip addressing bug #9
properly fixing bug #3
remove repeated calls to build_archive on parse Excel file bug #6

Co-Authored-By: Bradley van Ree <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bradbase