New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VDB function #48

Open

zulqasar opened this issue Apr 8, 2021 · 1 comment

zulqasar commented Apr 8, 2021

VDB function is erroneous and requires these changes:

line 162: periods = [x + 0.5 for x in periods] should be
periods = [x + delta_start for x in periods]

Reason:
0.5 is delta for HY conventions. MQ and MM conventions will have different values for delta_start.

Collaborator

strichter commented May 26, 2021

@zulqasar Would you mind creating a PR with tests?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment