chore: add acceptance tests

bpg · bpg · commit b035bffd0fbf · 2025-10-25T13:50:36.000-04:00
Signed-off-by: Pavel Boldyrev &lt;627562+bpg@users.noreply.github.com&gt;
diff --git a/fwprovider/test/resource_container_test.go b/fwprovider/test/resource_container_test.go
@@ -38,9 +38,9 @@ func TestAccResourceContainer(t *testing.T) {
 	accTestContainerIDClone := 100000 + rand.Intn(99999)
 
 	te.AddTemplateVars(map[string]interface{}{
-		"ImageFileName":            imageFileName,
-		"TestContainerID":          accTestContainerID,
-		"TestContainerIDClone":     accTestContainerIDClone,
+		"ImageFileName":        imageFileName,
+		"TestContainerID":      accTestContainerID,
+		"TestContainerIDClone": accTestContainerIDClone,
 	})
 
 	err := te.NodeStorageClient().DownloadFileByURL(context.Background(), &storage.DownloadURLPostRequestBody{
@@ -685,9 +685,9 @@ func TestAccResourceContainer(t *testing.T) {
 			}`, WithRootUser()),
 				Check: resource.ComposeTestCheckFunc(
 					ResourceAttributes(accTestContainerName, map[string]string{
-						"initialization.0.hostname": "test-dns-update",
-						"initialization.0.dns.#":    "1",
-						"initialization.0.dns.0.domain": "example.com",
+						"initialization.0.hostname":        "test-dns-update",
+						"initialization.0.dns.#":           "1",
+						"initialization.0.dns.0.domain":    "example.com",
 						"initialization.0.dns.0.servers.#": "2",
 						"initialization.0.dns.0.servers.0": "8.8.8.8",
 						"initialization.0.dns.0.servers.1": "8.8.4.4",
diff --git a/fwprovider/test/resource_vm_test.go b/fwprovider/test/resource_vm_test.go
@@ -770,6 +770,117 @@ func TestAccResourceVMNetwork(t *testing.T) {
 				),
 			},
 		}},
+		{"multiple network devices removal", []resource.TestStep{
+			{
+				Config: te.RenderConfig(`
+				resource "proxmox_virtual_environment_vm" "test_vm" {
+					node_name = "{{.NodeName}}"
+					started   = false
+
+					network_device {
+						bridge = "vmbr0"
+						model  = "virtio"
+					}
+
+					network_device {
+						bridge = "vmbr1"
+						model  = "virtio"
+					}
+				}`),
+				Check: resource.ComposeTestCheckFunc(
+					ResourceAttributes("proxmox_virtual_environment_vm.test_vm", map[string]string{
+						"network_device.#":        "2",
+						"network_device.0.bridge": "vmbr0",
+						"network_device.1.bridge": "vmbr1",
+					}),
+				),
+			},
+			{
+				Config: te.RenderConfig(`
+				resource "proxmox_virtual_environment_vm" "test_vm" {
+					node_name = "{{.NodeName}}"
+					started   = false
+
+					# Only keep the first network device
+					network_device {
+						bridge = "vmbr0"
+						model  = "virtio"
+					}
+				}`),
+				Check: resource.ComposeTestCheckFunc(
+					ResourceAttributes("proxmox_virtual_environment_vm.test_vm", map[string]string{
+						"network_device.#":        "1",
+						"network_device.0.bridge": "vmbr0",
+					}),
+				),
+			},
+			{
+				Config: te.RenderConfig(`
+				resource "proxmox_virtual_environment_vm" "test_vm" {
+					node_name = "{{.NodeName}}"
+					started   = false
+				}`),
+				Check: resource.ComposeTestCheckFunc(
+					ResourceAttributes("proxmox_virtual_environment_vm.test_vm", map[string]string{
+						"network_device.#": "0",
+					}),
+				),
+			},
+		}},
+		{"network device state consistency", []resource.TestStep{
+			{
+				Config: te.RenderConfig(`
+				resource "proxmox_virtual_environment_vm" "test_vm" {
+					node_name = "{{.NodeName}}"
+					started   = false
+
+					network_device {
+						bridge = "vmbr0"
+						model  = "virtio"
+					}
+				}`),
+				Check: resource.ComposeTestCheckFunc(
+					ResourceAttributes("proxmox_virtual_environment_vm.test_vm", map[string]string{
+						"network_device.#":        "1",
+						"network_device.0.bridge": "vmbr0",
+						"network_device.0.model":  "virtio",
+					}),
+				),
+			},
+			{
+				// This step tests that the state is read correctly after network device removal
+				Config: te.RenderConfig(`
+				resource "proxmox_virtual_environment_vm" "test_vm" {
+					node_name = "{{.NodeName}}"
+					started   = false
+				}`),
+				Check: resource.ComposeTestCheckFunc(
+					ResourceAttributes("proxmox_virtual_environment_vm.test_vm", map[string]string{
+						"network_device.#": "0",
+					}),
+				),
+			},
+			{
+				// This step tests that we can add network devices back after removal
+				Config: te.RenderConfig(`
+				resource "proxmox_virtual_environment_vm" "test_vm" {
+					node_name = "{{.NodeName}}"
+					started   = false
+
+					network_device {
+						bridge = "vmbr0"
+						model  = "virtio"
+					}
+				}`),
+				Check: resource.ComposeTestCheckFunc(
+					ResourceAttributes("proxmox_virtual_environment_vm.test_vm", map[string]string{
+						"network_device.#":        "1",
+						"network_device.0.bridge": "vmbr0",
+						"network_device.0.model":  "virtio",
+					}),
+				),
+			},
+		}},
 	}
 
 	for _, tt := range tests {
diff --git a/proxmoxtf/provider/provider.go b/proxmoxtf/provider/provider.go
@@ -80,7 +80,6 @@ func providerConfigure(ctx context.Context, d *schema.ResourceData) (interface{}
 		csrfPreventionToken = v.(string)
 	}
 
-	//nolint:staticcheck
 	if v, ok := d.GetOkExists(mkProviderAPIToken); ok {
 		apiToken = v.(string)
 	}
@@ -94,7 +93,6 @@ func providerConfigure(ctx context.Context, d *schema.ResourceData) (interface{}
 		username = v.(string)
 	}
 
-	//nolint:staticcheck
 	if v, ok := d.GetOkExists(mkProviderPassword); ok {
 		password = v.(string)
 	}
diff --git a/proxmoxtf/resource/vm/network/network.go b/proxmoxtf/resource/vm/network/network.go
@@ -101,6 +101,7 @@ func valueOrDefault[T any](v *T, def T) T {
 	if v == nil {
 		return def
 	}
+
 	return *v
 }
 
@@ -171,6 +172,7 @@ func ReadNetworkDeviceObjects(d *schema.ResourceData, vmConfig *vms.GetResponseD
 					if trunks == nil {
 						return ""
 					}
+
 					return strings.Trim(strings.Join(strings.Fields(fmt.Sprint(trunks)), ";"), "[]")
 				}(netDevice.Trunks),
 			})

Original file line number	Diff line number	Diff line change
`@@ -80,7 +80,6 @@ func providerConfigure(ctx context.Context, d *schema.ResourceData) (interface{}`
`80`	`80`	`csrfPreventionToken = v.(string)`
`81`	`81`	`}`
`82`	`82`
`83`		`- //nolint:staticcheck`
`84`	`83`	`if v, ok := d.GetOkExists(mkProviderAPIToken); ok {`
`85`	`84`	`apiToken = v.(string)`
`86`	`85`	`}`
`@@ -94,7 +93,6 @@ func providerConfigure(ctx context.Context, d *schema.ResourceData) (interface{}`
`94`	`93`	`username = v.(string)`
`95`	`94`	`}`
`96`	`95`
`97`		`- //nolint:staticcheck`
`98`	`96`	`if v, ok := d.GetOkExists(mkProviderPassword); ok {`
`99`	`97`	`password = v.(string)`
`100`	`98`	`}`
Original file line number	Diff line number	Diff line change
`@@ -101,6 +101,7 @@ func valueOrDefault[T any](v *T, def T) T {`
`101`	`101`	`if v == nil {`
`102`	`102`	`return def`
`103`	`103`	`}`
	`104`	`+`
`104`	`105`	`return *v`
`105`	`106`	`}`
`106`	`107`
`@@ -171,6 +172,7 @@ func ReadNetworkDeviceObjects(d schema.ResourceData, vmConfig vms.GetResponseD`
`171`	`172`	`if trunks == nil {`
`172`	`173`	`return ""`
`173`	`174`	`}`
	`175`	`+`
`174`	`176`	`return strings.Trim(strings.Join(strings.Fields(fmt.Sprint(trunks)), ";"), "[]")`
`175`	`177`	`}(netDevice.Trunks),`
`176`	`178`	`})`