Merge pull request #95 from TLuthra/download-disconnect

tluthra · tluthra · commit 657f761acb45 · 2015-03-19T18:56:49.000-07:00
Long download requests
diff --git a/src/main/java/com/box/sdk/BoxFile.java b/src/main/java/com/box/sdk/BoxFile.java
@@ -121,9 +121,9 @@ public void download(OutputStream output, ProgressListener listener) {
             }
         } catch (IOException e) {
             throw new BoxAPIException("Couldn't connect to the Box API due to a network error.", e);
+        } finally {
+            response.disconnect();
         }
-
-        response.disconnect();
     }
 
     /**
@@ -175,9 +175,9 @@ public void downloadRange(OutputStream output, long rangeStart, long rangeEnd, P
             }
         } catch (IOException e) {
             throw new BoxAPIException("Couldn't connect to the Box API due to a network error.", e);
+        } finally {
+            response.disconnect();
         }
-
-        response.disconnect();
     }
 
     @Override

Original file line number	Diff line number	Diff line change
`@@ -121,9 +121,9 @@ public void download(OutputStream output, ProgressListener listener) {`
`121`	`121`	`}`
`122`	`122`	`} catch (IOException e) {`
`123`	`123`	`throw new BoxAPIException("Couldn't connect to the Box API due to a network error.", e);`
	`124`	`+ } finally {`
	`125`	`+ response.disconnect();`
`124`	`126`	`}`
`125`		`-`
`126`		`- response.disconnect();`
`127`	`127`	`}`
`128`	`128`
`129`	`129`	`/**`
`@@ -175,9 +175,9 @@ public void downloadRange(OutputStream output, long rangeStart, long rangeEnd, P`
`175`	`175`	`}`
`176`	`176`	`} catch (IOException e) {`
`177`	`177`	`throw new BoxAPIException("Couldn't connect to the Box API due to a network error.", e);`
	`178`	`+ } finally {`
	`179`	`+ response.disconnect();`
`178`	`180`	`}`
`179`		`-`
`180`		`- response.disconnect();`
`181`	`181`	`}`
`182`	`182`
`183`	`183`	`@Override`