Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BOUT++ fails with most recent version #116

Open
dschwoerer opened this issue Oct 8, 2024 · 2 comments
Open

BOUT++ fails with most recent version #116

dschwoerer opened this issue Oct 8, 2024 · 2 comments

Comments

@dschwoerer
Copy link
Contributor

Traceback (most recent call last):
  File "/home/test/BOUT-dev/build/tests/integrated/test-drift-instability/runtest", line 10, in <module>
    from boututils.file_import import file_import
ModuleNotFoundError: No module named 'boututils.file_import'

Was that deleted in https://github.com/boutproject/boutdata/pull/112/files#diff-377222da5cb71dc6fafc0e1bf783eb448fa3418169de03b3013c151982ba0c4c

@dschwoerer
Copy link
Contributor Author

There are 60 uses in 41 files:

[dave@panhu: BOUT-dev]👍 git grep file_import|wc
     60     189    4486
[dave@panhu: BOUT-dev]👍 git grep file_import|cut -d: -f1| uniq|wc
     41      41    1516

Some are .pro files, but several are py.
They are also used in the examples, so likely also in production code.

Assuming this is not inherently broken (which does not seem to be the case) I will revert this ...

@ZedThree
Copy link
Member

ZedThree commented Oct 8, 2024

Thanks, nice catch @dschwoerer

DataFile now has __getitem__, so I think this can still be removed, but probably best fix uses of it first

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants