Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use of loader-specific image_filenames() in NetVLAD #628

Open
akshay-krishnan opened this issue Apr 25, 2023 · 0 comments
Open

Use of loader-specific image_filenames() in NetVLAD #628

akshay-krishnan opened this issue Apr 25, 2023 · 0 comments
Assignees
@travisdriver

Comments

@akshay-krishnan
Copy link
Collaborator

image_filenames used in NetVLAD retreiver (for visualization) is not present in all loaders (not a base class member). This will crash if used with a loader that does not have the method.

gtsfm/gtsfm/retriever/netvlad_retriever.py

Line 200 in 581f84a

query_names = loader.image_filenames()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@travisdriver travisdriver

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@akshay-krishnan @travisdriver