New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

”scalar“ is a bad name for a variable or parameter #131

Open

dabrahams opened this issue Jul 18, 2020 · 0 comments

Assignees

Collaborator

dabrahams commented Jul 18, 2020

Describe the role, not the type! e.g.

  /// Returns Jacobians that scale each element by `scalar`.
  func jacobians(scalar: Double) -> AnyGaussianFactorArrayBuffer {

should be:

  /// Returns Jacobians that scale each element by `scaleFactor`.
  func jacobians(scaleFactor: Double) -> AnyGaussianFactorArrayBuffer {

dabrahams assigned marcrasi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment