-
Notifications
You must be signed in to change notification settings - Fork 192
post-pull pre-stage stage (update hooks) #640
Copy link
Copy link
Open
Labels
area/clientRelated to the client/CLIRelated to the client/CLIarea/configRelated to configurationRelated to configurationarea/updatesRelated to upgrading between versionsRelated to upgrading between versionsenhancementNew feature or requestNew feature or requesttriagedThis issue appears to be validThis issue appears to be valid
Metadata
Metadata
Assignees
Labels
area/clientRelated to the client/CLIRelated to the client/CLIarea/configRelated to configurationRelated to configurationarea/updatesRelated to upgrading between versionsRelated to upgrading between versionsenhancementNew feature or requestNew feature or requesttriagedThis issue appears to be validThis issue appears to be valid
This relates to:
Basically...I think it'd be a powerful general feature if we supported a flow that did:
One simple way to do this would be to define a new
bootc-pre-stage.targetsystemd unit that we run in between what currently happens when one typesbootc upgrade.This would be a clearly very powerful general mechanism that would allow implementing things like "logically bound container images" outside of bootc core code itself. A base image (or user code) could define which container images to pull via whatever mechanisms and file format it wants.
One could do arbitrary things like check compatibility (relates to #632 and #610)
The downside of course is that being so general, it'd be easy to use for things that would probably be best done elsewhere. I think we'd still eventually want higher level and more declarative/opinionated mechanisms for some of the problems here (especially the container binding one).
(This also tangentially relates to #2 in that it'd probably be a bit more elegant if we internally split up bits of the bootc upgrade process internally into units)
But...in ostree we already merged e.g. ostreedev/ostree#2569 which is currently a very special case.
Actually, a notable detail here is that
bootc-pre-stage.targetas proposed would get mutable access to the current/etcand the global/var, i.e. it'd be ordered beforeostree-finalize-staged.target.