chore: update note-c (#34)

* remove note-c before re-add

* Squashed 'src/note-c/' content from commit 9dc64f0

git-subtree-dir: src/note-c
git-subtree-split: 9dc64f06dfadc50847c92dd0b4bc7e8946ae6c1d

* chore: update note-c

Author: zfields

CONTRIBUTING.md

@@ -42,13 +42,15 @@ clean up inconsistent whitespace )
   We will happily reopen the issue.
 
 ## Submitting a Pull Request
+
 1. [Fork][fork] the [official repository][repo].
 2. [Create a topic branch.][branch]
 3. Implement your feature or bug fix.
 4. Add, commit, and push your changes.
 5. [Submit a pull request.][pr]
 
 ## Notes
+
 * Please add tests if you changed code. Contributions without tests won't be
 * accepted. If you don't know how to add tests, please put in a PR and leave a
 * comment asking for help. We love helping!

library.properties

@@ -1,5 +1,5 @@
 name=Blues Wireless Notecard
-version=1.2.9
+version=1.2.10
 author=Blues Wireless
 maintainer=Blues Wireless <[email protected]>
 sentence=An easy to use Notecard Library for Arduino.

src/note-c/README.md

@@ -7,13 +7,11 @@ This library allows you to control a Notecard by writing a C
 or C++ program. Your program may programmatically configure Notecard and send
 Notes to [Notehub.io][notehub].
 
-This library is used by the [note-arduino library][note-arduino], which includes
-it as a git submodule.
+This library is used by the [note-arduino library][note-arduino], which includes it as a git submodule.
 
 ## Documentation
 
-The documentation for this library can be found
-[here](https://blues.github.io/note-c/html/index.html).
+The documentation for this library can be found [here](https://blues.github.io/note-c/html/index.html).
 
 ## Contributing
 
@@ -47,4 +45,4 @@ Copyright (c) 2019 Blues Inc. Released under the MIT license. See
 [note-arduino]: https://github.com/blues/note-arduino
 [note-go]: https://github.com/blues/note-go
 [note-python]: https://github.com/blues/note-python
-[code of conduct]: https://blues.github.io/opensource/code-of-conduct
+[code of conduct]: https://blues.github.io/opensource/code-of-conduct

src/note-c/n_helpers.c

@@ -396,9 +396,11 @@ int NoteGetEnvInt(const char *variable, int defaultVal) {
     @param   defaultVal The variable value.
     @param   buf (out) The buffer in which to place the variable value.
     @param   buflen The length of the output buffer.
+	@returns true if there is no error (JSON response with no explicit error)
 */
 /**************************************************************************/
-void NoteGetEnv(const char *variable, const char *defaultVal, char *buf, uint32_t buflen) {
+bool NoteGetEnv(const char *variable, const char *defaultVal, char *buf, uint32_t buflen) {
+	bool success = false;
     if (defaultVal == NULL)
         buf[0] = '\0';
     else
@@ -409,13 +411,15 @@ void NoteGetEnv(const char *variable, const char *defaultVal, char *buf, uint32_
         J *rsp = NoteRequestResponse(req);
         if (rsp != NULL) {
             if (!NoteResponseError(rsp)) {
+				success = true;
                 char *val = JGetString(rsp, "text");
                 if (val[0] != '\0')
                     strlcpy(buf, val, buflen);
             }
             NoteDeleteResponse(rsp);
         }
     }
+	return success;
 }
 
 //**************************************************************************/
@@ -830,7 +834,7 @@ bool NoteWake(int stateLen, void *state) {
         return false;
 
     // Send it a command to request the saved state
-    JAddBoolToObject(req, "sync", true);
+    JAddBoolToObject(req, "start", true);
     J *rsp = NoteRequestResponse(req);
     if (rsp == NULL)
         return false;
@@ -1074,7 +1078,7 @@ bool NoteAdd(const char *target, J *body, bool urgent) {
 
     // Initiate sync NOW if it's urgent
     if (urgent)
-        JAddBoolToObject(req, "sync", true);
+        JAddBoolToObject(req, "start", true);
 
     // Perform the transaction
     return NoteRequest(req);
@@ -1216,8 +1220,8 @@ bool NoteGetContact(char *nameBuf, int nameBufLen, char *orgBuf, int orgBufLen,
                 strlcpy(roleBuf, JGetString(rsp, "role"), roleBufLen);
             if (emailBuf != NULL)
                 strlcpy(emailBuf, JGetString(rsp, "email"), emailBufLen);
-            NoteDeleteResponse(rsp);
         }
+        NoteDeleteResponse(rsp);
     }
 
     return success;