chore: eliminate i2c test method (#48)

Author: zfields

keywords.txt

@@ -8,7 +8,6 @@ FUNCTIONS
 ==================================
 begin	KEYWORD2
 setDebugOutputStream	KEYWORD2
-i2cTest	KEYWORD2
 newCommand	KEYWORD2
 newRequest	KEYWORD2
 sendRequest	KEYWORD2

src/Notecard.cpp

@@ -147,10 +147,6 @@ namespace
     }
 }
 
-// 2018-06 ST Microelectronics has a HAL bug that causes an infinite hang.
-// This code enables us to exercise that code path to test the state of the bug.
-int _readLengthAdjustment = 0;
-
 /***************************************************************************
  PUBLIC FUNCTIONS
  ***************************************************************************/
@@ -228,20 +224,6 @@ void Notecard::clearDebugOutputStream()
     NoteSetFnDebugOutput(nullptr);
 }
 
-/**************************************************************************/
-/*!
-    @brief  Adjust the I2C read length.
-            Method enabling a developer to test the state of a known issue
-            with the I2C HAL on some ST Microelectronics boards.
-    @param    Adjustment
-              The read length to override.
-*/
-/**************************************************************************/
-void Notecard::i2cTest(int Adjustment)
-{
-    _readLengthAdjustment = Adjustment;
-}
-
 /**************************************************************************/
 /*!
     @brief  Creates a new request object for population by the host.

src/Notecard.h

@@ -126,7 +126,6 @@ class Notecard
     void begin(HardwareSerial &serial, int speed = 9600);
     void setDebugOutputStream(Stream &dbgserial);
     void clearDebugOutputStream(void);
-    void i2cTest(int Adjustment);
     J *newRequest(const char *request);
     J *newCommand(const char *request);
     bool sendRequest(J *req);