Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logic allows circular references #8

Open
mlueft opened this issue May 25, 2011 · 0 comments
Open

logic allows circular references #8

mlueft opened this issue May 25, 2011 · 0 comments

Comments

@mlueft
Copy link

mlueft commented May 25, 2011

Hi!

Thanks for this great tool. I am using it in my project and it saved me some time. While building and testing my frontend for editing I have seen the logic allows to make a node a child of itself or of one of it's children.

A fix is simple:

$newParent->getLeftValue() > $movedChild->getLeftValue()
&& $newParent->getRightValue() < $movedChild->getRightValue()

If this contition is true don't move the node.

regards,

michael

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant