Skip to content

Commit 2508756

Browse files
committed
use dependson for node
1 parent 2646125 commit 2508756

File tree

4 files changed

+6
-10
lines changed

4 files changed

+6
-10
lines changed

.devcontainer/claude-code/devcontainer-feature.json

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -16,12 +16,9 @@
1616
"containerEnv": {
1717
"CLAUDE_CONFIG_DIR": "/home/vscode/.claude"
1818
},
19-
"dependsOn": [
20-
"ghcr.io/devcontainers/features/node"
21-
],
22-
"installsAfter": [
23-
"ghcr.io/devcontainers/features/node"
24-
],
19+
"dependsOn": {
20+
"ghcr.io/devcontainers/features/node": {}
21+
},
2522
"mounts": [
2623
"source=${localEnv:HOME}/.claude/CLAUDE.md,target=/home/vscode/.claude/CLAUDE.md,type=bind,ro",
2724
"source=${localEnv:HOME}/.claude/settings.json,target=/home/vscode/.claude/settings.json,type=bind,ro",

.devcontainer/claude-code/install.sh

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,14 +9,13 @@ set -eu
99
install_claude_code() {
1010
echo "Installing Claude Code CLI globally..."
1111

12-
# Verify Node.js and npm are available
12+
# Verify Node.js and npm are available (should be installed via dependsOn)
1313
if ! command -v node >/dev/null || ! command -v npm >/dev/null; then
1414
cat <<EOF
1515
1616
ERROR: Node.js and npm are required but not found!
1717
18-
This should not happen as the Node.js feature is automatically installed
19-
via the 'installsAfter' mechanism in devcontainer-feature.json.
18+
This should not happen as the Node.js feature is declared in 'dependsOn'.
2019
2120
Please check:
2221
1. The devcontainer feature specification is correct

.devcontainer/devcontainer.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@
1818
}
1919
},
2020
"features": {
21-
"ghcr.io/devcontainers/features/node":{},
2221
"./claude-code": {}
2322

2423
// "ghcr.io/devcontainers/features/docker-in-docker:2": {}

.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -172,3 +172,4 @@ managed_context/metadata.json
172172
test_suite_analysis/metadata.json
173173

174174
.devpod/
175+
.devpod-internal/

0 commit comments

Comments
 (0)