Make blocking-physrep default

Signed-off-by: Mark Hannum <[email protected]>

Author: markhannum

db/phys_rep.c

@@ -57,7 +57,7 @@ typedef struct DB_Connection {
 int gbl_physrep_debug = 0;
 int gbl_physrep_reconnect_interval = 3600; // force re-registration every hour
 int gbl_physrep_reconnect_penalty = 0;
-int gbl_blocking_physrep = 0;
+int gbl_blocking_physrep = 1;
 int gbl_physrep_fanout = 8;
 int gbl_physrep_max_candidates = 6;
 int gbl_physrep_max_pending_replicants = 10;
@@ -1361,7 +1361,7 @@ static int do_wait_for_reverse_conn(cdb2_hndl_tp *repl_metadb) {
        This is the database/node that to replicant connects to retrieve and
        apply physical logs.
 */
-int gbl_physrep_pollms = 200;
+int gbl_physrep_pollms = 0;
 extern __thread int physrep_out_of_order;
 static void *physrep_worker(void *args)
 {
@@ -1376,6 +1376,7 @@ static void *physrep_worker(void *args)
     int is_revconn = -1;
     int last_revconn_check = 0;
     int last_update_registry = 0;
+    int pollms;
     LOG_INFO info;
     LOG_INFO prev_info;
     DB_Connection *repl_db_cnct = NULL;
@@ -1647,7 +1648,10 @@ static void *physrep_worker(void *args)
             do_truncate = 1;
         }
 sleep_and_retry:
-        poll(0, 0, gbl_physrep_pollms);
+        pollms = gbl_physrep_pollms;
+        if (pollms > 0) {
+            poll(0, 0, pollms);
+        }
     }
 
     if (repl_db_connected == 1) {

tests/tunables.test/t00_all_tunables.expected

@@ -82,7 +82,7 @@
 (name='blobmem_sz_thresh_kb', description='Sets the threshold (in KB) above which blobs are allocated by the blob allocator. (Default: 0)', type='INTEGER', value='-1', read_only='Y')
 (name='blobstripe', description='', type='BOOLEAN', value='ON', read_only='Y')
 (name='blocking_latches', description='Block on latch rather than deadlock', type='BOOLEAN', value='OFF', read_only='N')
-(name='blocking_physrep', description='Physical replicant blocks on select. (Default: off)', type='BOOLEAN', value='OFF', read_only='N')
+(name='blocking_physrep', description='Physical replicant blocks on select. (Default: off)', type='BOOLEAN', value='ON', read_only='N')
 (name='broadcast_check_rmtpol', description='Check rmtpol before sending triggers', type='BOOLEAN', value='ON', read_only='N')
 (name='broken_max_rec_sz', description='', type='INTEGER', value='0', read_only='Y')
 (name='broken_num_parser', description='', type='BOOLEAN', value='OFF', read_only='Y')
@@ -742,7 +742,7 @@
 (name='physrep_max_rollback', description='Maximum logs physrep can rollback. (Default: 0)', type='INTEGER', value='0', read_only='N')
 (name='physrep_metadb_host', description='List of physical replication metadb cluster hosts.', type='STRING', value=NULL, read_only='Y')
 (name='physrep_metadb_name', description='Physical replication metadb cluster name.', type='STRING', value=NULL, read_only='Y')
-(name='physrep_pollms', description='Physical replicant poll interval in milliseconds. (Default: 200)', type='INTEGER', value='200', read_only='N')
+(name='physrep_pollms', description='Physical replicant poll interval in milliseconds. (Default: 200)', type='INTEGER', value='0', read_only='N')
 (name='physrep_reconnect_interval', description='Reconnect interval for physical replicants (Default: 600)', type='INTEGER', value='3600', read_only='N')
 (name='physrep_reconnect_penalty', description='Physrep wait seconds before retry to the same node. (Default: 5)', type='INTEGER', value='0', read_only='N')
 (name='physrep_repl_host', description='Current physrep host.', type='STRING', value=NULL, read_only='Y')