add big5 to AuthnCredential

Signed-off-by: Emelia Lei <[email protected]>

Author: emelialei88

src/groups/bmq/bmqt/bmqt_authncredential.cpp

@@ -33,8 +33,8 @@ namespace bmqt {
 // CREATORS
 
 AuthnCredential::AuthnCredential(bslma::Allocator* allocator)
-: d_mechanism("", allocator)
-, d_data(bsl::vector<char>(), allocator)
+: d_mechanism(allocator)
+, d_data(allocator)
 {
     // NOTHING
 }
@@ -58,12 +58,38 @@ AuthnCredential::AuthnCredential(const AuthnCredential& other,
 
 AuthnCredential::AuthnCredential(bslmf::MovableRef<AuthnCredential> otherRef,
                                  bslma::Allocator*                  allocator)
-: d_mechanism(bslmf::MovableRefUtil::access(otherRef).d_mechanism, allocator)
-, d_data(bslmf::MovableRefUtil::access(otherRef).d_data, allocator)
+: d_mechanism(bslmf::MovableRefUtil::move(
+                  bslmf::MovableRefUtil::access(otherRef).d_mechanism),
+              allocator)
+, d_data(bslmf::MovableRefUtil::move(
+             bslmf::MovableRefUtil::access(otherRef).d_data),
+         allocator)
 {
     // NOTHING
 }
 
+// ASSIGNMENT
+
+AuthnCredential& AuthnCredential::operator=(const AuthnCredential& rhs)
+{
+    if (this != &rhs) {
+        d_mechanism = rhs.d_mechanism;
+        d_data      = rhs.d_data;
+    }
+    return *this;
+}
+
+AuthnCredential&
+AuthnCredential::operator=(bslmf::MovableRef<AuthnCredential> rhsRef)
+{
+    AuthnCredential& rhs = bslmf::MovableRefUtil::access(rhsRef);
+    if (this != &rhs) {
+        d_mechanism = bslmf::MovableRefUtil::move(rhs.d_mechanism);
+        d_data      = bslmf::MovableRefUtil::move(rhs.d_data);
+    }
+    return *this;
+}
+
 AuthnCredential::~AuthnCredential()
 {
     // NOTHING

src/groups/bmq/bmqt/bmqt_authncredential.h

@@ -41,24 +41,22 @@ class AuthnCredential {
     bsl::vector<char> d_data;       // authentication data
 
   private:
-    // NOT IMPLEMENTED
-
-    /// Copy constructor and assignment operator are not implemented.
-    AuthnCredential(const AuthnCredential*);             // = delete;
-    AuthnCredential& operator=(const AuthnCredential&);  // = delete;
+    // NOT IMPLEMENTED (delete non-allocator creators)
+    AuthnCredential(const AuthnCredential&) BSLS_KEYWORD_DELETED;
+    AuthnCredential(AuthnCredential&&) BSLS_KEYWORD_DELETED;
 
   public:
     // TRAITS
     BSLMF_NESTED_TRAIT_DECLARATION(AuthnCredential, bslma::UsesBslmaAllocator)
 
     // CREATORS
-
     AuthnCredential(bslma::Allocator* allocator = 0);
 
-    AuthnCredential(const AuthnCredential& other, bslma::Allocator* allocator);
+    AuthnCredential(const AuthnCredential& other,
+                    bslma::Allocator*      allocator = 0);
 
     AuthnCredential(bslmf::MovableRef<AuthnCredential> other,
-                    bslma::Allocator*                  allocator);
+                    bslma::Allocator*                  allocator = 0);
 
     /// Create an `AuthnCredential` object with the specified `mechanism`
     /// and `data`, using the specified `allocator` to supply memory.  If
@@ -69,6 +67,10 @@ class AuthnCredential {
 
     ~AuthnCredential();
 
+    // ASSIGNMENT (no allocator parameters)
+    AuthnCredential& operator=(const AuthnCredential& rhs);
+    AuthnCredential& operator=(bslmf::MovableRef<AuthnCredential> rhs);
+
     // MANIPULATORS
     AuthnCredential& setMechanism(const bsl::string& mechanism);
     AuthnCredential& setData(const bsl::vector<char>& data);