IT: rm unrelevant, less logging in CI

Signed-off-by: Evgeny Malygin <emalygin@bloomberg.net>

Author: 678098

bmq-sdk/src/main/java/com/bloomberg/bmq/impl/BrokerSession.java

@@ -475,7 +475,11 @@ public void stopAsync(Duration timeout) {
                         () ->
                                 brokerConnection.stop(
                                         (BrokerConnection.StopStatus status) -> {
-                                            logger.info("Stop callback: {}", status);
+                                            if (status == BrokerConnection.StopStatus.SUCCESS) {
+                                                logger.debug("Stop callback: {}", status);
+                                            } else {
+                                                logger.warn("Stop callback: {}", status);
+                                            }
                                             // TODO: handle error status
                                             connectionStopFuture.complete(null);
                                         },
@@ -502,7 +506,7 @@ public void stopAsync(Duration timeout) {
                         },
                         scheduler);
 
-        logger.info("Broker connection is stopping.");
+        logger.debug("Broker connection is stopping.");
     }
 
     private void addHostHealthMonitorHandler() {

bmq-sdk/src/test/java/com/bloomberg/bmq/impl/BrokerSessionTest.java

@@ -16,6 +16,7 @@
 package com.bloomberg.bmq.impl;
 
 import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertInstanceOf;
 import static org.junit.jupiter.api.Assertions.assertNotNull;
 import static org.junit.jupiter.api.Assertions.assertNull;
 import static org.junit.jupiter.api.Assertions.assertTrue;
@@ -183,9 +184,9 @@ public void verifySessionEvent(BrokerSessionEvent.Type type) {
             Event event = nextEvent();
             assertNotNull(event);
 
-            logger.info("Verify session event: {}", event);
+            logger.trace("Verify session event: {}", event);
 
-            assertTrue(event instanceof BrokerSessionEvent);
+            assertInstanceOf(BrokerSessionEvent.class, event);
 
             assertEquals(type, ((BrokerSessionEvent) event).getEventType());
         }

bmq-sdk/src/test/java/com/bloomberg/bmq/it/util/BmqBrokerTestServer.java

@@ -126,19 +126,28 @@ public static BmqBrokerTestServer createStoppedBroker(int port) {
     private void init(int waitTime) throws IOException, InterruptedException {
         final String envPath = BmqBroker.brokerDir();
 
+        if (envPath.isEmpty()) {
+            throw new IllegalArgumentException(
+                    "Empty 'it.brokerDir' provided, no path to the broker");
+        }
+
         // Cleanup from previous run. Delete named pipe if it's there
         File np = new File(envPath + "/bmqbrkr.ctl");
         if (np.exists()) {
             logger.info("Deleting orphan bmqbrkr.ctl");
-            np.delete();
+            if (!np.delete()) {
+                logger.error("Failed to remove orphan bmqbrkr.ctl: {}", np.getPath());
+            }
         }
 
         // Since we run multiple tests at the same time starting instances
         // of BlazingMQ broker in the same location (BMQ_PREFIX),
         // we need to create a tmp folder for storage, log and stat files
         tmpFolder = makeTempDir(envPath, "localBMQ_");
 
-        ProcessBuilder pb = new ProcessBuilder("./run");
+        ProcessBuilder pb =
+                new ProcessBuilder(
+                        "./run", "-p", Integer.toString(sessionOptions.brokerUri().getPort()));
 
         final Path storagePath = tmpFolder.resolve("storage");
 
@@ -149,11 +158,6 @@ private void init(int waitTime) throws IOException, InterruptedException {
 
         outputFile = new File(tmpFolder.resolve("output").toString());
 
-        // Common environment vars
-        env.put("BMQ_PORT", String.valueOf(sessionOptions.brokerUri().getPort()));
-        env.put("BMQ_HOSTTAGS_FILE", "/bb/bin/bbcpu.lst");
-        env.put("PYTHONPATH", envPath + "/python");
-
         pb.directory(new File(envPath));
 
         logger.info("BlazingMQ Broker BMQ_PREFIX: [{}]", env.get("BMQ_PREFIX"));
@@ -171,7 +175,16 @@ private void init(int waitTime) throws IOException, InterruptedException {
         if (!process.isAlive()) {
             logger.error(
                     "Failed to start broker process after waiting for [{}] seconds.", waitTime);
-            throw new IllegalStateException("Failed to start broker process");
+
+            StringBuilder sb = new StringBuilder();
+            sb.append("Failed to start broker process, rc = ")
+                    .append(process.exitValue())
+                    .append(", dir = [ ")
+                    .append(envPath)
+                    .append(" ], cmd = [ ")
+                    .append(String.join(" ", pb.command()))
+                    .append(" ],");
+            throw new IllegalStateException(sb.toString());
         }
 
         pid = (int) getPidOfProcess(process);

bmq-sdk/src/test/resources/log4j2.properties

@@ -9,6 +9,9 @@ rootLogger.appenderRef.stdout.ref = STDOUT
 #logger.applicationData.name = com.bloomberg.bmq.impl.infr.proto.ApplicationData
 #logger.applicationData.level = debug
 
+logger.brokerSession.name = com.bloomberg.bmq.impl.BrokerSession
+logger.brokerSession.level = warn
+
 # Explicitly set BrokerSession logger to INFO level in order to
 # always see stats in log
 #logger.brokerSession.name = com.bloomberg.bmq.impl.BrokerSession