Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Before enabling strong ownership features in the iOS wallet, ensure we handle some backcompat cases #33

Open
kimdhamilton opened this issue Aug 23, 2017 · 0 comments

Comments

@kimdhamilton
Copy link
Member

This issue describes the originally reported problem: blockchain-certificates/BlockcertsFramework-iOS#33

I pushed commits to the framework and to this repo (e6462ac) that addressed the immediate concern of initializing keychains properly.

Part of the change was to future-proof for wallets that have already handed out keys, as follows:

Saves index state in under a new name (even for existing implementations), which will enable existing wallets (that have already used keys from the former derivation) to know the max index that was used. This will allow us recover ownership, for example when the wallet supports features such as proving ownership of keys.

This backcompat is required only for Blockcerts wallets where public addresses were generated before this fix (which we can detect by presence of a certain key in the user defaults).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants