Changing ID Protection in Blesta either fails or else deletes Nameservers records in Blesta and in RTR

[johnheenan]

Changing ID Protection in Blesta either fails or else deletes Nameservers records in Blesta and in RTR

Using Blesta 5.12.3 and PHP 8.2.29

---

Blesta before:

---

RTR before:

---

Blesta After on one .com domain with history of change on Blesta:

Failure to change ID Protection on Blesta and RTR but no nameserver deletion on Blesta or RTR.

---

Blesta After on another .com domain with less history of change on Blesta:

After change, ID Protection shows as enabled on Blesta

---

However on RTR shows no ID protection change and has deleted nameserver records:

[johnheenan]

For the message above 'The host ..... does not exist', the host named does not correspond to the host in the current nameserver records in Blesta or RTR. It corresponds to a previous nameserver record.

[johnheenan]

I confirm the nameserver deletion problem has been fixed with Blesta 5.13.

The 'ID Protection' configurable option change has not been fixed. From Blesta logs, no API calls are made. It takes four clicks from a client screen to change 'ID Protection', but there is no corresponding change on RTR. The client clicks required are:

1. Click on Change Configurable Options
2. Toggle enabled button on or off
3. Click on Review
4. Click on Save

I cannot find a way in admin to examine if the client has set 'ID Protection' or not. If I need to set or unset it for a client, then I need to lo enter the 'login as client screen'. As noted above, for RTR setting ID Protection from the Blesta client has no effect on RTR. In 'edit service' as below, there is nothing in the 'add-ons' tab to show status or to configure. Currently to set or unset for a client, I would need to set it in Blesta client as a non-actioned record only and set it separately in RTR

Minor but annoying: in admin, clicking on 'manage domain', takes us to 'edit domain' with the selection of new tabs now available. Clicking on ''edit service' provides us with more tabs but no way to go back to 'manage domain' without going back to the start by listing services.

[johnheenan]

In the Blesta namesilo module, code around the following handles API calls to namesilo required for ID Protection changes:
https://github.com/blesta/module-namesilo/blob/9de5d09357fe448d1ee739de9f6f554933256f96/namesilo.php#L828

In the Blesta RTR (realtime_register) module, there is no code in the equivalent file to make the API call:
https://github.com/blesta/module-realtime_register/blob/master/realtime_register.php

While the Blesta ID Protection setting is read and can be changed for RTR, there is no code to take corresponding action through an API call to RTR.

[johnheenan]

Along with manual editing of database, the pull request above fixed all reported problems of this issue.

The specific database edits were in the service fields table. A particular service_id for a domain occurs either once or five times in this table. If once, the key is domain and the value is the name of the domain. If occurs five times then the four other key values are ns1, ns2, ns3 and ns4.

All values ns1 to ns4 need to be empty if thes keys exist. Suppose ns1 and ns2 values have old values, then ID Protection update fails. The solution was to delete these old values (with ns1 and ns2 keys were left in place). Very easily reproduced by editing ns key values in this table.

I am not closing this issue yet, even though the pull request and manual database edits have fixed the reported problem for me, for the reason following, unless it becomes a separate issue.

The nameserver values are read successfully from RTR by API and are updated by API without changing ns1 to ns4 key values in the Blesta service_fields table. Yet the key values are read from the table during an update and cause an update failure if they are not empty.

This is a refinement of issue, and I don't think it should become a sperate issue at the moment to keep context.

[johnheenan]

I think I have got sorted out what is happening.

First, the error I stated above is reproducible only if the stored nameserver is not a valid DNS name.

I have added another commit to the pull request at b071010

As stated in the additional commit:

Blesta uses API to the registrar to get current nameserver values.
Since editService currently does not update the corresponding local
nameserver service fields if they are changed by Blesta on the
registrar by API, these service fields become out of date and must
not be used.

I assume the nameserver service fields get populated at purchase. These are used by addService if they are not empty. They should not be used again until such time as they are updated when nameservers are updated.

The reason I was getting empty nameserver service fields is that I was supressing 'use module' in order to connect to an existing domain already setup on RTR that had been transferred from another registrar without using Blesta.

[johnheenan]

As a result of closely examining code paths, I have added another commit to the PR. The code path review shows it does not matter that the ns service fields become out of date or are not even present.

The total code change for the PR is now 8 lines added and 12 lines deleted.

0fb6b8b