update tests & add back coveralls

Author: rjocoleman

.github/dependabot.yml

@@ -5,7 +5,7 @@ updates:
     schedule:
       interval: "weekly"
     open-pull-requests-limit: 10
-    target-branch: "main"
+    target-branch: "master"
     versioning-strategy: "auto"
     allow:
       - dependency-type: "direct"
@@ -19,7 +19,7 @@ updates:
     schedule:
       interval: "weekly"
     open-pull-requests-limit: 10
-    target-branch: "main"
+    target-branch: "master"
     labels:
       - "dependencies"
       - "github-actions"

.github/workflows/tests.yml

@@ -26,7 +26,7 @@ jobs:
       with:
         php-version: ${{ matrix.php-versions }}
         extensions: mbstring, intl
-        coverage: xdebug
+        coverage: pcov
 
     - name: Validate composer.json and composer.lock
       run: composer validate --strict
@@ -43,8 +43,8 @@ jobs:
     - name: Install dependencies
       run: composer update ${{ matrix.composer-flags }}
 
-    - name: Run test suite
-      run: composer run-script test
+    - name: Run test suite with coverage
+      run: vendor/bin/phpunit --coverage-text --coverage-clover build/logs/clover.xml
 
     - name: Check coding standards
       run: composer run-script cs-check
@@ -54,3 +54,11 @@ jobs:
 
     - name: Check PHP compatibility
       run: composer run-script compat
+
+    - name: Upload coverage to Coveralls
+      if: matrix.php-versions == '8.4'
+      env:
+        COVERALLS_REPO_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+      run: |
+        mkdir -p build/logs
+        vendor/bin/php-coveralls --coverage_clover=build/logs/clover.xml -v

.gitignore

@@ -1,3 +1,5 @@
 /vendor
 composer.lock
 /.phpunit.cache
+/coverage
+/build

README.md

@@ -1,7 +1,7 @@
 # Composer Installer
 
 [![Tests](https://github.com/blesta/composer-installer/actions/workflows/tests.yml/badge.svg)](https://github.com/blesta/composer-installer/actions/workflows/tests.yml)
-[![PHPStan](https://img.shields.io/badge/PHPStan-level%207-brightgreen.svg)](https://phpstan.org/)
+[![Coverage Status](https://coveralls.io/repos/blesta/composer-installer/badge.svg?branch=master&service=github)](https://coveralls.io/github/blesta/composer-installer?branch=master)
 
 A library for installing Blesta extensions using [composer](http://getcomposer.org).
 

composer.json

@@ -13,7 +13,8 @@
         "squizlabs/php_codesniffer": "^3.13",
         "composer/composer": "^2.0",
         "phpstan/phpstan": "^2.1",
-        "phpcompatibility/php-compatibility": "^9.3"
+        "phpcompatibility/php-compatibility": "^9.3",
+        "php-coveralls/php-coveralls": "^2.8"
     },
     "autoload": {
         "psr-4": {

tests/Unit/BlestaInstallerTest.php

@@ -28,7 +28,7 @@ protected function setUp(): void
     }
 
     /**
-     * @covers ::getLocations
+     * Test getLocations property
      */
     public function testGetLocations(): void
     {

tests/Unit/InstallerPluginTest.php

@@ -14,6 +14,7 @@
 use InvalidArgumentException;
 use PHPUnit\Framework\MockObject\MockObject;
 use React\Promise\PromiseInterface;
+use RuntimeException;
 
 /**
  * @covers \Blesta\Composer\Installer\InstallerPlugin
@@ -67,8 +68,7 @@ public function testGetInstallPath(): void
     }
 
     /**
-     * @covers ::getInstallPath
-     * @covers ::supportedType
+     * Test getInstallPath throws exception for invalid types
      */
     public function testGetInstallPathException(): void
     {
@@ -84,9 +84,7 @@ public function testGetInstallPathException(): void
     }
 
     /**
-     * @covers ::uninstall
-     * @covers ::getInstallPath
-     * @covers ::supportedType
+     * Test uninstall functionality
      */
     public function testUninstall(): void
     {
@@ -118,7 +116,7 @@ public function testUninstall(): void
     }
 
     /**
-     * @covers ::uninstall
+     * Test uninstall throws exception when package not found
      */
     public function testUninstallException(): void
     {
@@ -197,5 +195,98 @@ public function testSupportedType(): void
         // Test invalid types
         $this->assertFalse($method->invoke($installer, 'invalid'));
         $this->assertFalse($method->invoke($installer, 'blesta')); // No hyphen
+        $this->assertFalse($method->invoke($installer, 'unknown-type')); // Unknown base type with hyphen
+    }
+
+    /**
+     * Test getInstallPath with a custom type that doesn't have an installer class
+     */
+    public function testGetInstallPathWithMissingInstallerClass(): void
+    {
+        // Override the supportedTypes array to have a non-existent installer class
+        $installer = new class ($this->io, $this->composer) extends InstallerPlugin {
+            protected array $supportedTypes = [
+                'custom' => 'NonExistentInstaller'
+            ];
+
+            protected function supportedType(string $type): string|false
+            {
+                if ($type === 'test-invalid-type') {
+                    return 'custom';
+                }
+                return false;
+            }
+        };
+
+        $package = $this->createMock(PackageInterface::class);
+        $package->expects($this->once())
+            ->method('getType')
+            ->willReturn('test-invalid-type');
+
+        $this->expectException(RuntimeException::class);
+        $this->expectExceptionMessage('Failed to create installer for package type "test-invalid-type":');
+
+        $installer->getInstallPath($package);
+    }
+
+    /**
+     * Test uninstall with exception during getInstallPath
+     */
+    public function testUninstallWithGetInstallPathException(): void
+    {
+        $package = $this->createMock(PackageInterface::class);
+        $package->expects($this->once())
+            ->method('getType')
+            ->willReturn('invalid-type');
+        $package->expects($this->once())
+            ->method('getName')
+            ->willReturn('test/package');
+
+        $repo = $this->createMock(InstalledRepositoryInterface::class);
+        $repo->expects($this->once())
+            ->method('hasPackage')
+            ->willReturn(true);
+        $repo->expects($this->once())
+            ->method('removePackage')
+            ->with($package);
+
+        $installer = new InstallerPlugin($this->io, $this->composer);
+
+        // Expect error to be written
+        $this->io->expects($this->once())
+            ->method('writeError')
+            ->with($this->stringContains('Error during uninstall of test/package:'));
+
+        $result = $installer->uninstall($repo, $package);
+        $this->assertNull($result);
+    }
+
+    /**
+     * Test supports method with exception during installer creation
+     */
+    public function testSupportsWithException(): void
+    {
+        // Create a custom installer that will throw an exception
+        $installer = new class ($this->io, $this->composer) extends InstallerPlugin {
+            protected array $supportedTypes = [
+                'custom' => 'NonExistentInstaller'
+            ];
+
+            protected function supportedType(string $type): string|false
+            {
+                if ($type === 'test-invalid-type') {
+                    return 'custom';
+                }
+                return false;
+            }
+        };
+
+        // Expect error to be written
+        $this->io->expects($this->once())
+            ->method('writeError')
+            ->with($this->stringContains('Error checking support for package type "test-invalid-type":'));
+
+        $result = $installer->supports('test-invalid-type');
+        $this->assertFalse($result);
     }
 }

tests/Unit/InstallerTest.php

@@ -37,7 +37,7 @@ protected function setUp(): void
     }
 
     /**
-     * @covers ::activate
+     * Test activate method
      */
     public function testActivate(): void
     {
@@ -68,7 +68,7 @@ public function testActivate(): void
     }
 
     /**
-     * @covers ::deactivate
+     * Test deactivate method
      */
     public function testDeactivate(): void
     {
@@ -89,7 +89,7 @@ public function testDeactivate(): void
     }
 
     /**
-     * @covers ::uninstall
+     * Test uninstall method
      */
     public function testUninstall(): void
     {