Fix Optimisers.jl wrapper on GPU#85
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #85 +/- ##
=======================================
Coverage 92.22% 92.22%
=======================================
Files 25 25
Lines 3217 3217
=======================================
Hits 2967 2967
Misses 250 250 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
@blegat Sorry, move what exactly? |
Owner
Author
|
Sorry, this lacked context. In ArrayDiff.jl/test/OptimisersSolver.jl Lines 10 to 15 in c0bfb74 there is a simple wrapper to use Optimisers.jl using the NLPModels interface. Using then NLPModelsJuMP.jl, it can also be used from JuMP. This is jsut a file in the test here but it would be probably better to move it as a separate package or as a package extension of Optimisers.jl |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@dpo Would it make sense to move this into a package in JSO ?