Dynamic limit of LED output type

- wled#5014

Author: blazoncek

wled00/data/settings_leds.htm

@@ -13,8 +13,9 @@
 		function gT(t)     { for (let type of d.ledTypes) if (t == type.i) return type; } // getType from available ledTypes
 		function isPWM(t)  { return gT(t).t.charAt(0) === "A"; }    // is PWM type
 		function isAna(t)  { return gT(t).t === "" || isPWM(t); }   // is analog type
-		function isDig(t)  { return gT(t).t === "D" || isD2P(t); }  // is digital type
+		function isD1P(t)  { return gT(t).t === "D"; }              // is digital 1 pin type
 		function isD2P(t)  { return gT(t).t === "2P"; }             // is digital 2 pin type
+		function isDig(t)  { return isD1P(t) || isD2P(t); }         // is digital type
 		function isNet(t)  { return gT(t).t === "N"; }              // is network type
 		function isVir(t)  { return gT(t).t === "V" || isNet(t); }  // is virtual type
 		function hasRGB(t) { return !!(gT(t).c & 0x01); }           // has RGB
@@ -254,10 +255,10 @@
 			}
 
 			// enable/disable LED fields
+			updateTypeDropdowns(change);
 			let dC = 0; // count of digital buses (for parallel I2S)
 			let LTs = d.Sf.querySelectorAll("#mLC select[name^=LT]");
 			LTs.forEach((s,i)=>{
-				s.disabled = (i < LTs.length-1); // prevent changing type (as we can't update options)
 				var n = s.name.substring(2,3); // bus number (0-Z)
 				var t = parseInt(s.value);
 				memu += getMem(t, n); // calc memory
@@ -405,17 +406,7 @@
 		function addLEDs(n,init=true) {
 			var o = gEBCN("iST");
 			var i = o.length;
-			let disable = (sel,opt) => { sel.querySelectorAll(opt).forEach((o)=>{o.disabled=true;}); }
-
 			var f = gId("mLC");
-			let digitalB = 0, analogB = 0, twopinB = 0, virtB = 0;
-			f.querySelectorAll("select[name^=LT]").forEach((s)=>{
-				let t = s.value;
-				if (isDig(t) && !isD2P(t)) digitalB++;
-				if (isD2P(t)) twopinB++;
-				if (isPWM(t)) analogB += numPins(t); // each GPIO is assigned to a channel
-				if (isVir(t)) virtB++;
-			});
 
 			if ((n==1 && i>=36) || (n==-1 && i==0)) return; // used to be i>=maxB+maxV when virtual buses were limited (now :"0123456789ABCDEFGHIJKLMNOPQRSTUVWXYZ")
 			var s = chrID(i);
@@ -424,7 +415,7 @@
 // npm run build has trouble minimizing spaces inside string
 				var cn = `<div class="iST" draggable="true" ondragstart="hDS(event)" id="l${s}" style="cursor:grab;">
 <hr class="sml">
-<span id="n${s}">${i+1}</span>:
+<span id="n${s}">${++i}</span>:
 <select name="LT${s}" onchange="UI(true)"></select><br>
 <div id="abl${s}">
 mA/LED: <select name="LL${s}" onchange="enLA(this);UI();">
@@ -450,7 +441,7 @@
 <div id="dig${s}w" style="display:none">Swap: <select name="WO${s}"><option value="0">None</option><option value="1">W & B</option><option value="2">W & G</option><option value="3">W & R</option><option data-opt="CCT" value="4">WW & CW</option></select></div>
 <div id="dig${s}l" style="display:none">Clock: <select name="SP${s}"><option value="0">Slowest</option><option value="1">Slow</option><option value="2">Normal</option><option value="3">Fast</option><option value="4">Fastest</option></select></div>
 <div>
-<span id="psd${s}">Start:</span> <input type="number" name="LS${s}" id="ls${s}" class="l starts" min="0" max="8191" value="${lastEnd(i)}" oninput="startsDirty[${i}]=true;UI();" required />&nbsp;
+<span id="psd${s}">Start:</span> <input type="number" name="LS${s}" id="ls${s}" class="l starts" min="0" max="8191" value="${lastEnd(i-1)}" oninput="startsDirty[${i}]=true;UI();" required />&nbsp;
 <div id="dig${s}c" style="display:inline">Length: <input type="number" name="LC${s}" class="l" min="1" max="${maxPB}" value="1" required oninput="UI()" /></div><br>
 </div>
 <span id="p0d${s}">GPIO:</span><input type="number" name="L0${s}" required class="s" onchange="UI();pinUpd(this);"/>
@@ -480,25 +471,18 @@
 					}
 				});
 				enLA(gN("LL"+s)); // update LED mA
-				// disable inappropriate LED types
 				let sel = gN("LT"+s);
-				// 32 & S2 supports mono I2S as well as parallel so we need to take that into account; S3 only supports parallel
-				let maxDB = maxD - (is32() || isS2() || isS3() ? (!gN("PR").checked)*8 - (!isS3()) : 0); // adjust max digital buses if parallel I2S is not used
-				if (digitalB >= maxDB) disable(sel,'option[data-type="D"]'); // NOTE: see isDig()
-				if (twopinB  >= 2)     disable(sel,'option[data-type="2P"]'); // NOTE: see isD2P() (we will only allow 2 2pin buses)
-				disable(sel,`option[data-type^="${'A'.repeat(maxA-analogB+1)}"]`); // NOTE: see isPWM()
-				sel.selectedIndex = sel.querySelector('option:not(:disabled)').index;
+				sel.selectedIndex = sel.querySelector('option:not([data-type])').index; // select On/Off by default
 			}
 			if (n==-1) {
-				o[--i].remove();--i;
-				o[i].querySelector("[name^=LT]").disabled = false;
+				o[--i].remove();
 			}
 
-			gId("+").style.display = (i<35) ? "inline":"none"; // was maxB+maxV-1 when virtual buses were limited (now :"0123456789ABCDEFGHIJKLMNOPQRSTUVWXYZ")
-			gId("-").style.display = (i>0) ? "inline":"none";
+			gId("+").style.display = (i<36) ? "inline":"none"; // was maxB+maxV-1 when virtual buses were limited (now :"0123456789ABCDEFGHIJKLMNOPQRSTUVWXYZ")
+			gId("-").style.display = (i>1) ? "inline":"none";
 
 			if (!init) {
-				UI();
+				UI(true);
 			}
 		}
 
@@ -828,6 +812,36 @@
 			}
 			return opt;
 		}
+		// dynamically enforce bus type availability based on current usage
+		function updateTypeDropdowns(change=false) {
+			let LTs = d.Sf.querySelectorAll("#mLC select[name^=LT]");
+			let digitalB = 0, analogB = 0, twopinB = 0, virtB = 0;
+			// count currently used buses (including last added bus)
+			LTs.forEach((sel,i) => {
+				let t = parseInt(sel.value);
+				if (isD1P(t)) digitalB++;
+				if (isPWM(t)) analogB += numPins(t);
+				if (isD2P(t)) twopinB++;
+				if (isVir(t)) virtB++;
+			});
+			// now enable/disable type options according to limits in dropdowns
+			LTs.forEach((sel,i) => {
+				const last = i == LTs.length-1;
+				const curType = parseInt(sel.value);
+				const disable = (q) => sel.querySelectorAll(q).forEach(o => o.disabled = true);
+				const enable  = (q) => sel.querySelectorAll(q).forEach(o => o.disabled = false);
+				enable('option'); // reset all first
+				// max digital count
+				let maxDB = maxD - ((is32() || isS2() || isS3()) ? (!d.Sf["PR"].checked) * 8 - (!isS3()) : 0);
+				// disallow adding more of a type that has reached its limit
+				if (digitalB >= maxDB && !isD1P(curType)) disable('option[data-type="D"]');
+				if (twopinB  >= 2     && !isD2P(curType)) disable('option[data-type="2P"]');
+				// determine available analog pins
+				disable(`option[data-type^="${'A'.repeat(maxA - analogB + (isPWM(curType) ? numPins(curType) : 0) + 1)}"]`);
+				// if last added bus has an invalid type, change it to first available
+				if (last && sel.selectedOptions[0].disabled) sel.selectedIndex = sel.querySelector('option:not(:disabled)').index;
+			});
+		}
 	</script>
 	<style>@import url("style.css");</style>
 </head>