self.skiprows = int(skiprows or self.header) in backends/sql_csv.py fails with error

[user32000]

/Applications/anaconda/envs/python3/lib/python2.7/site-packages/odo/backends/sql_csv.pyc in init(self, element, csv, delimiter, header, na_value, lineterminator, quotechar, escapechar, encoding, skiprows, bind, **kwargs)
45 self.escapechar = escapechar
46 self.encoding = encoding
---> 47 self.skiprows = int(skiprows or self.header)
48 self._bind = getbind(element, bind)
49

TypeError: int() argument must be a string or a number, not 'NoneType'

[user32000]

Replacing this line with

self.skiprows = skiprows if self.header is None else int(self.header)

seems to solve the issue and allow CSV import with skiprows set to 0.

I'm a bit unclear about how I'd submit that as a change... any chance somebody could talk me through it?

[llllllllll]

Hey, thanks for reporting this!

The easiest way to submit this as a change is to open a pull request against this project. To do that, you first need to fork the project by clicking the "fork" button in the top right. Then clone your local copy of the repo with $ git clone git@github.com:user32000/odo.git. In that repo, create a new branch with git checkout -b skiprows-fix. Here you can make changes to fix the error you are seeing. When you are happy with what you have, run git status to see which files need to be committed. use git add <FILE> for each file that you want to make changes to. When all the files are added, you can collect the changes into a single commit with git commit. This will open your editor where you can write a short message about what this change is for. Then, you can run git push --set-upstream origin skiprows-fix to push your new branch to github. Finally, when you navigate to your project you should see a new button which will open a PR for your branch against this project where we can review the changes. Hopefully this helps, also, sorry if you were already familiar with this workflow and were just asking about the particulars of the odo workflow.

[user32000]

Thanks Joe, that is exactly what I needed. Much appreciated. Best, Michael

…

On 6 Dec 2016, at 22:13, Joe Jevnik ***@***.***> wrote: Hey, thanks for reporting this! The easiest way to submit this as a change is to open a pull request against this project. To do that, you first need to fork the project by clicking the "fork" button in the top right. Then clone your local copy of the repo with $ git clone ***@***.***:user32000/odo.git. In that repo, create a new branch with git checkout -b skiprows-fix. Here you can make changes to fix the error you are seeing. When you are happy with what you have, run git status to see which files need to be committed. use git add <FILE> for each file that you want to make changes to. When all the files are added, you can collect the changes into a single commit with git commit. This will open your editor where you can write a short message about what this change is for. Then, you can run git push --set-upstream origin skiprows-fix to push your new branch to github. Finally, when you navigate to your project you should see a new button which will open a PR for your branch against this project where we can review the changes. Hopefully this helps, also, sorry if you were already familiar with this workflow and were just asking about the particulars of the odo workflow. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#510 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AP9i7vIHfcrvyOrKyG9_nzcdSDh0yamwks5rFd4RgaJpZM4LFRO1>.