Build fails on VS2022 due to c++ version error

[Seyedof]

Hi Guys,
I'm porting my engine code to bgfx, using Visual Studio 2022, the code builds with bgfx.h included and some initialization code works fine, but as soon as I include the bgfx_utils.h file (to load some textures), my build fails with this error:

fatal error C1189: #error: "C++14 standard support is required to build.
This is thrown at bx/include/bx/platform.h around line# 450

I've already set my project settings in VS to use C++ 20, and even placing this code:

#if defined(__cplusplus)
#define STRINGIFY(s) XSTRINGIFY(s)
#define XSTRINGIFY(s) #s
#pragma message ("__cplusplus=" STRINGIFY(__cplusplus))

I get:

__cplusplus=199711L

I've also added all bgfx, bx, compat include paths to my include path settings of project.

any help on how to solve this annoying issue?

Sorry found the solution:
in MSVC this should be added in Project Settings->C/C++->All Options->Additional Options:
manually add /Zc:__cplusplus this way the __cplusplus gets the correct c++ version number!

[bkaradzic]

Sorry found the solution:
in MSVC this should be added in Project Settings->C/C++->All Options->Additional Options:
manually add /Zc:__cplusplus this way the __cplusplus gets the correct c++ version number!

Yep, that's MSVC issue, and it's handled in provided scripts here:
https://github.com/bkaradzic/bx/blob/aed1086c48884b1b4f1c2f9af34c5198624263f6/scripts/toolchain.lua#L525

[Seyedof]

Thanks for quick response.
I see you already see it in your codebase, I am adding bgfx to my already existing project/codebase, should care about all compiler flags and preprocessor definitions and follow your settings.
Also have a couple more questions, will open another topic to keep things organized.

[bkaradzic]

should care about all compiler flags and preprocessor definitions and follow your settings

Depends. You should be careful with optimization settings. Basically you should apply all non-optimization settings, rebuild everything test it behaves as expected, then add all those optimization setting and redo the test.