Skip to content

Conversation

@Jingo88
Copy link
Contributor

@Jingo88 Jingo88 commented Jan 28, 2026

🎟️ Tracking

PM-31387

πŸ“” Objective

The logic for showArchiveButton and showUnarchiveButton were not updating with the latest action value so when a user navigated from viewing an item to creating a new item, the archive and trash buttons would stay in the footer. Added the action to ngOnChanges here.

πŸ“Έ Screenshots

PM-31387.mov

@Jingo88 Jingo88 requested a review from a team as a code owner January 28, 2026 22:42
@github-actions
Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Details – 77c351be-4aaf-4bfa-b490-1b8557023187

Great job! No new security vulnerabilities introduced in this pull request

@codecov
Copy link

codecov bot commented Jan 28, 2026

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
βœ… Project coverage is 43.18%. Comparing base (0740c03) to head (4818463).
⚠️ Report is 2 commits behind head on main.
βœ… All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...sktop/src/vault/app/vault/item-footer.component.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #18640      +/-   ##
==========================================
- Coverage   43.18%   43.18%   -0.01%     
==========================================
  Files        3675     3675              
  Lines      107808   107818      +10     
  Branches    16257    16259       +2     
==========================================
  Hits        46558    46558              
- Misses      59286    59296      +10     
  Partials     1964     1964              

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

πŸš€ New features to boost your workflow:
  • πŸ“¦ JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants