[PM-24467] Update SDK models

Author: shane-melton

libs/common/src/vault/abstractions/cipher-risk.service.ts

@@ -1,5 +1,5 @@
 import type {
-  CipherRisk,
+  CipherRiskResult,
   CipherRiskOptions,
   ExposedPasswordResult,
   PasswordReuseMap,
@@ -23,7 +23,7 @@ export abstract class CipherRiskService {
     ciphers: CipherView[],
     userId: UserId,
     options?: CipherRiskOptions,
-  ): Promise<CipherRisk[]>;
+  ): Promise<CipherRiskResult[]>;
 
   /**
    * Compute password risk for a single cipher by its ID. Will automatically build a password reuse map
@@ -37,7 +37,7 @@ export abstract class CipherRiskService {
     cipherId: CipherId,
     userId: UserId,
     checkExposed?: boolean,
-  ): Promise<CipherRisk>;
+  ): Promise<CipherRiskResult>;
 
   /**
    * Build a password reuse map for the given ciphers.
@@ -52,4 +52,4 @@ export abstract class CipherRiskService {
 }
 
 // Re-export SDK types for convenience
-export type { CipherRisk, CipherRiskOptions, ExposedPasswordResult, PasswordReuseMap };
+export type { CipherRiskResult, CipherRiskOptions, ExposedPasswordResult, PasswordReuseMap };

libs/common/src/vault/services/default-cipher-risk.service.spec.ts

@@ -1,7 +1,7 @@
 import { mock } from "jest-mock-extended";
 import { BehaviorSubject } from "rxjs";
 
-import type { CipherRisk, CipherRiskOptions, CipherId } from "@bitwarden/sdk-internal";
+import type { CipherRiskOptions, CipherId, CipherRiskResult } from "@bitwarden/sdk-internal";
 
 import { asUuid } from "../../platform/abstractions/sdk/sdk.service";
 import { MockSdkService } from "../../platform/spec/mock-sdk.service";
@@ -38,7 +38,7 @@ describe("DefaultCipherRiskService", () => {
       const mockClient = sdkService.simulate.userLogin(mockUserId);
       const mockCipherRiskClient = mockClient.vault.mockDeep().cipher_risk.mockDeep();
 
-      const mockRiskResults: CipherRisk[] = [
+      const mockRiskResults: CipherRiskResult[] = [
         {
           id: mockCipherId1 as any,
           password_strength: 3,
@@ -163,7 +163,7 @@ describe("DefaultCipherRiskService", () => {
       const mockClient = sdkService.simulate.userLogin(mockUserId);
       const mockCipherRiskClient = mockClient.vault.mockDeep().cipher_risk.mockDeep();
 
-      const mockRiskResults: CipherRisk[] = [
+      const mockRiskResults: CipherRiskResult[] = [
         {
           id: mockCipherId1 as any,
           password_strength: 3,
@@ -316,7 +316,7 @@ describe("DefaultCipherRiskService", () => {
       mockCipherRiskClient.password_reuse_map.mockReturnValue(mockReuseMap);
 
       // Mock compute_risk result
-      const mockRiskResult: CipherRisk = {
+      const mockRiskResult: CipherRiskResult = {
         id: mockCipherId1 as any,
         password_strength: 3,
         exposed_result: { type: "NotChecked" },

libs/common/src/vault/services/default-cipher-risk.service.ts

@@ -1,12 +1,12 @@
 import { firstValueFrom, switchMap } from "rxjs";
 
 import { CipherService } from "@bitwarden/common/vault/abstractions/cipher.service";
-import type {
+import {
   CipherLoginDetails,
-  CipherRisk,
   CipherRiskOptions,
   PasswordReuseMap,
   CipherId,
+  CipherRiskResult,
 } from "@bitwarden/sdk-internal";
 
 import { SdkService, asUuid } from "../../platform/abstractions/sdk/sdk.service";
@@ -25,7 +25,7 @@ export class DefaultCipherRiskService implements CipherRiskServiceAbstraction {
     ciphers: CipherView[],
     userId: UserId,
     options?: CipherRiskOptions,
-  ): Promise<CipherRisk[]> {
+  ): Promise<CipherRiskResult[]> {
     const loginDetails = this.mapToLoginDetails(ciphers);
 
     if (loginDetails.length === 0) {
@@ -50,7 +50,7 @@ export class DefaultCipherRiskService implements CipherRiskServiceAbstraction {
     cipherId: CipherId,
     userId: UserId,
     checkExposed: boolean = true,
-  ): Promise<CipherRisk> {
+  ): Promise<CipherRiskResult> {
     // Get all ciphers for the user
     const allCiphers = await firstValueFrom(this.cipherService.cipherViews$(userId));