Skip to content

[PM-31614] Added new UI for the Email verification on sends#6488

Open
aj-rosado wants to merge 1 commit intomainfrom
PM-31614/update-add-edit-send-ui-email-auth
Open

[PM-31614] Added new UI for the Email verification on sends#6488
aj-rosado wants to merge 1 commit intomainfrom
PM-31614/update-add-edit-send-ui-email-auth

Conversation

@aj-rosado
Copy link
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-31614

📔 Objective

Initial PR to add the layout changes for the Email Verification option on Sends.
The chagnes are behind a feature flag and should not have any impact when it is turned off.

This does not add the changes to the server and misses validations that will be added on subsequent PRs.

📸 Screenshots

Screenshot_1770402169 Screenshot_1770402172 Screenshot_1770402191 Screenshot_1770402349

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@aj-rosado aj-rosado requested review from a team and david-livefront as code owners February 6, 2026 18:27
@github-actions github-actions bot added app:password-manager Bitwarden Password Manager app context app:authenticator Bitwarden Authenticator app context labels Feb 6, 2026
@aj-rosado aj-rosado added the ai-review Request a Claude code review label Feb 6, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Feb 6, 2026

Logo
Checkmarx One – Scan Summary & Details5f2d1192-4eda-4ce6-9396-98076ac8a199

Great job! No new security vulnerabilities introduced in this pull request

@codecov
Copy link

codecov bot commented Feb 6, 2026

Codecov Report

❌ Patch coverage is 94.02985% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.32%. Comparing base (cbe13d2) to head (b6b7002).

Files with missing lines Patch % Lines
...tools/feature/send/addedit/AddEditSendViewModel.kt 85.71% 5 Missing and 2 partials ⚠️
...ls/feature/send/addedit/util/SendViewExtensions.kt 50.00% 2 Missing and 1 partial ⚠️
...d/addedit/components/AddEditSendAuthTypeChooser.kt 97.18% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6488      +/-   ##
==========================================
+ Coverage   86.30%   86.32%   +0.01%     
==========================================
  Files         783      781       -2     
  Lines       56432    56536     +104     
  Branches     8153     8179      +26     
==========================================
+ Hits        48705    48805     +100     
+ Misses       4887     4886       -1     
- Partials     2840     2845       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-review Request a Claude code review app:authenticator Bitwarden Authenticator app context app:password-manager Bitwarden Password Manager app context

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant