Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ROCm] Allowing for more flexibility in matching ROCm-specific PyTorch wheels to the installed ROCm version #1461

Open
nikhil-tensorwave opened this issue Dec 19, 2024 · 0 comments

Comments

@nikhil-tensorwave
Copy link

Feature request

When compiling bitsandbytes from source on ROCm, it should allow for having a ROCm-specific PyTorch wheel within 1 minor version; i.e. if ROCm 6.3.x is installed, then any of pytorch+rocm 6.2.x, 6.3.x, or 6.4.x should work.

Motivation

PyTorch wheels lag behind ROCm releases, especially for stable versions. Additionally, there are very significant performance improvements made to nightly builds of PyTorch, which also tend to lag behind ROCm releases. ROCm 6.3 has been released with additional improvements, but bitsandbytes no longer works due to the mismatch of installed ROCm and the PyTorch wheel ROCm version. Allowing for more flexibility would help with continued work with bitsandbytes on ROCm 6.3.

Your contribution

We can submit a PR making this change and additionally test compilation and performance on our MI300X servers. Please help direct us to where in the codebase this check for matching ROCm versions happens.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants