Skip to content

Conversation

@oren1zo
Copy link

@oren1zo oren1zo commented Nov 2, 2025

Description of the change

Skip extracting client certificates from the PKCS#12 keystore when ZOO_TLS_CLIENT_AUTH=none so the readiness probe can continue using openssl s_client without blocking on an empty password, while still validating the secure client port.

Benefits

Prevents zombie openssl pkcs12 processes when mutual TLS is disabled but preserves end-to-end TLS verification for the health check.

Possible drawbacks

None known, the probe continues to use the TLS listener and only omits mutual-auth when it is not required

Applicable issues

Related posts:
bitnami/charts#29603
#76831

Additional information

@github-actions github-actions bot added zookeeper triage Triage is needed labels Nov 2, 2025
@github-actions github-actions bot requested a review from carrodher November 2, 2025 16:54
@carrodher
Copy link
Member

carrodher commented Nov 2, 2025

Thank you for initiating this pull request. We appreciate your effort. This is just a friendly reminder that signing your commits is important. Your signature certifies that you either authored the patch or have the necessary rights to contribute to the changes. You can find detailed information on how to do this in the “Sign your work” section of our contributing guidelines.

Feel free to reach out if you have any questions or need assistance with the signing process.

@oren1zo
Copy link
Author

oren1zo commented Nov 3, 2025

Thank you for initiating this pull request. We appreciate your effort. This is just a friendly reminder that signing your commits is important. Your signature certifies that you either authored the patch or have the necessary rights to contribute to the changes. You can find detailed information on how to do this in the “Sign your work” section of our contributing guidelines.

Feel free to reach out if you have any questions or need assistance with the signing process.

Thanks! Could you point me to the exact steps to sign my previous commits correctly for this PR?

@carrodher
Copy link
Member

You can find the steps in the failing action: https://github.com/bitnami/containers/pull/88022/checks?check_run_id=54302290335

@oren1zo oren1zo marked this pull request as draft November 4, 2025 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

triage Triage is needed zookeeper

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants