Skip to content

Commit c27ccb2

Browse files
authored
fix build warnings (#696)
* update * update infer * only upload on success * std has net9 target ---------
1 parent f73fe17 commit c27ccb2

File tree

4 files changed

+5
-4
lines changed

4 files changed

+5
-4
lines changed

.github/workflows/devskim.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,10 +18,10 @@ jobs:
1818
security-events: write
1919
steps:
2020
- name: Checkout code
21-
uses: actions/checkout@v2
21+
uses: actions/checkout@v4
2222
- name: Run DevSkim scanner
2323
uses: microsoft/DevSkim-Action@v1
2424
- name: Upload DevSkim scan results to GitHub Security tab
25-
uses: github/codeql-action/upload-sarif@v2
25+
uses: github/codeql-action/upload-sarif@v3
2626
with:
2727
sarif_file: devskim-results.sarif

.github/workflows/gate.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -135,6 +135,7 @@ jobs:
135135
name: Coveralls Finished
136136
needs: build
137137
runs-on: ubuntu-latest
138+
if: ${{ success() }} # Only run if all build jobs succeed
138139
steps:
139140
- name: Coveralls Finished
140141
uses: coverallsapp/github-action@master

.github/workflows/infer.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,6 @@ jobs:
3131
binary-path: BitFaster.Caching/bin
3232

3333
- name: Upload SARIF output to GitHub Security Center
34-
uses: github/codeql-action/upload-sarif@v2
34+
uses: github/codeql-action/upload-sarif@v3
3535
with:
3636
sarif_file: infer-out/report.sarif

BitFaster.Caching.UnitTests.Std/BitFaster.Caching.UnitTests.Std.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
<Project Sdk="Microsoft.NET.Sdk">
22

33
<PropertyGroup>
4-
<TargetFrameworks>net6.0</TargetFrameworks>
4+
<TargetFrameworks>net6.0;net9.0</TargetFrameworks>
55
<LangVersion>9.0</LangVersion>
66
</PropertyGroup>
77

0 commit comments

Comments
 (0)