more ctor (#34)

Author: bitfaster

BitFaster.Caching.UnitTests/Lru/ClassicLruTests.cs

@@ -40,6 +40,14 @@ public void WhenComparerIsNullCtorThrows()
             constructor.Should().Throw<ArgumentNullException>();
         }
 
+        [Fact]
+        public void ConstructAddAndRetrieveWithDefaultCtorReturnsValue()
+        {
+            var x = new ConcurrentTLru<int, int>(3);
+
+            x.GetOrAdd(1, k => k).Should().Be(1);
+        }
+
         [Fact]
 		public void WhenItemIsAddedCountIsCorrect()
 		{

BitFaster.Caching.UnitTests/Lru/ConcurrentLruTests.cs

@@ -49,6 +49,14 @@ public void WhenComparerIsNullCtorThrows()
             constructor.Should().Throw<ArgumentNullException>();
         }
 
+        [Fact]
+        public void ConstructAddAndRetrieveWithDefaultCtorReturnsValue()
+        {
+            var x = new ConcurrentLru<int, int>(3);
+
+            x.GetOrAdd(1, k => k).Should().Be(1);
+        }
+
         [Fact]
 		public void WhenItemIsAddedCountIsCorrect()
 		{

BitFaster.Caching.UnitTests/Lru/ConcurrentTLruTests.cs

@@ -21,6 +21,14 @@ public ConcurrentTLruTests()
             lru = new ConcurrentTLru<int, string>(1, capacity, EqualityComparer<int>.Default, timeToLive);
         }
 
+        [Fact]
+        public void ConstructAddAndRetrieveWithDefaultCtorReturnsValue()
+        {
+            var x = new ConcurrentTLru<int, int>(3);
+
+            x.GetOrAdd(1, k => k).Should().Be(1);
+        }
+
         [Fact]
         public async Task WhenItemIsExpiredItIsRemoved()
         {

BitFaster.Caching.UnitTests/Lru/FastConcurrentLruTests.cs

@@ -19,5 +19,13 @@ public void ConstructAddAndRetrieveWithCustomComparerReturnsValue()
             lru.TryGet("FOO", out var value).Should().BeTrue();
             value.Should().Be(1);
         }
+
+        [Fact]
+        public void ConstructAddAndRetrieveWithDefaultCtorReturnsValue()
+        {
+            var x = new FastConcurrentLru<int, int>(3);
+
+            x.GetOrAdd(1, k => k).Should().Be(1);
+        }
     }
 }

BitFaster.Caching.UnitTests/Lru/FastConcurrentTLruTests.cs

@@ -19,5 +19,13 @@ public void ConstructAddAndRetrieveWithCustomComparerReturnsValue()
             lru.TryGet("FOO", out var value).Should().BeTrue();
             value.Should().Be(1);
         }
+
+        [Fact]
+        public void ConstructAddAndRetrieveWithDefaultCtorReturnsValue()
+        {
+            var x = new FastConcurrentTLru<int, int>(3);
+
+            x.GetOrAdd(1, k => k).Should().Be(1);
+        }
     }
 }

BitFaster.Caching/Lru/ClassicLru.cs

@@ -26,6 +26,11 @@ public sealed class ClassicLru<K, V> : ICache<K, V>
         private long requestHitCount;
         private long requestTotalCount;
 
+        public ClassicLru(int capacity)
+            : this(Defaults.ConcurrencyLevel, capacity, EqualityComparer<K>.Default)
+        { 
+        }
+
         public ClassicLru(int concurrencyLevel, int capacity, IEqualityComparer<K> comparer)
         {
             if (capacity < 3)

BitFaster.Caching/Lru/ConcurrentLru.cs

@@ -8,6 +8,11 @@ namespace BitFaster.Caching.Lru
 {
     public sealed class ConcurrentLru<K, V> : TemplateConcurrentLru<K, V, LruItem<K, V>, LruPolicy<K, V>, HitCounter>
     {
+        public ConcurrentLru(int capacity)
+            : base(Defaults.ConcurrencyLevel, capacity, EqualityComparer<K>.Default, new LruPolicy<K, V>(), new HitCounter())
+        {
+        }
+
         public ConcurrentLru(int concurrencyLevel, int capacity, IEqualityComparer<K> comparer)
             : base(concurrencyLevel, capacity, comparer, new LruPolicy<K, V>(), new HitCounter())
         {

BitFaster.Caching/Lru/ConcurrentTLru.cs

@@ -8,6 +8,11 @@ namespace BitFaster.Caching.Lru
 {
     public sealed class ConcurrentTLru<K, V> : TemplateConcurrentLru<K, V, TimeStampedLruItem<K, V>, TLruDateTimePolicy<K, V>, HitCounter>
     {
+        public ConcurrentTLru(int capacity)
+            : base(Defaults.ConcurrencyLevel, capacity, EqualityComparer<K>.Default, new TLruDateTimePolicy<K, V>(), new HitCounter())
+        { 
+        }
+
         public ConcurrentTLru(int concurrencyLevel, int capacity, IEqualityComparer<K> comparer, TimeSpan timeToLive)
             : base(concurrencyLevel, capacity, comparer, new TLruDateTimePolicy<K, V>(timeToLive), new HitCounter())
         {

BitFaster.Caching/Lru/Defaults.cs

@@ -0,0 +1,14 @@
+using System;
+using System.Collections.Generic;
+using System.Text;
+
+namespace BitFaster.Caching.Lru
+{
+    internal static class Defaults
+    {
+        public static int ConcurrencyLevel
+        {
+            get { return Environment.ProcessorCount; }
+        }
+    }
+}

BitFaster.Caching/Lru/FastConcurrentLru.cs

@@ -6,6 +6,11 @@ namespace BitFaster.Caching.Lru
 {
     public sealed class FastConcurrentLru<K, V> : TemplateConcurrentLru<K, V, LruItem<K, V>, LruPolicy<K, V>, NullHitCounter>
     {
+        public FastConcurrentLru(int capacity)
+            : base(Defaults.ConcurrencyLevel, capacity, EqualityComparer<K>.Default, new LruPolicy<K, V>(), new NullHitCounter())
+        {
+        }
+
         public FastConcurrentLru(int concurrencyLevel, int capacity, IEqualityComparer<K> comparer)
             : base(concurrencyLevel, capacity, comparer, new LruPolicy<K, V>(), new NullHitCounter())
         {