From 26106d08b81d4ba406ed17f91695deb54dcba632 Mon Sep 17 00:00:00 2001 From: ltiseanu Date: Fri, 31 Jan 2025 10:36:43 +0200 Subject: [PATCH 1/5] fix display --- _src-lp/blocks/banner/banner.css | 4 ++++ _src-lp/blocks/banner/banner.scss | 4 ++++ 2 files changed, 8 insertions(+) diff --git a/_src-lp/blocks/banner/banner.css b/_src-lp/blocks/banner/banner.css index 4ed557ab..c66f7c71 100644 --- a/_src-lp/blocks/banner/banner.css +++ b/_src-lp/blocks/banner/banner.css @@ -220,6 +220,10 @@ border-radius: 22px; } +.section.banner-container.hasslide .block table tr td a { + color: white; +} + .section.banner-container .banner .blue-box tr td:first-of-type { margin-right: 10px; } diff --git a/_src-lp/blocks/banner/banner.scss b/_src-lp/blocks/banner/banner.scss index 88e94b0a..32ac3fc6 100644 --- a/_src-lp/blocks/banner/banner.scss +++ b/_src-lp/blocks/banner/banner.scss @@ -221,6 +221,10 @@ border-radius: 22px; } +.section.banner-container.hasslide .block table tr td a { + color: white; +} + .section.banner-container .banner .blue-box tr td:first-of-type { margin-right: 10px; } From ca639cb5adff5c919bcceaafb847935f44e62041 Mon Sep 17 00:00:00 2001 From: ltiseanu Date: Mon, 3 Feb 2025 09:36:42 +0200 Subject: [PATCH 2/5] visble disocunt --- _src-lp/blocks/new-prod-boxes/new-prod-boxes.css | 1 + _src-lp/blocks/new-prod-boxes/new-prod-boxes.scss | 1 + 2 files changed, 2 insertions(+) diff --git a/_src-lp/blocks/new-prod-boxes/new-prod-boxes.css b/_src-lp/blocks/new-prod-boxes/new-prod-boxes.css index 3d7d334d..4aa87d38 100644 --- a/_src-lp/blocks/new-prod-boxes/new-prod-boxes.css +++ b/_src-lp/blocks/new-prod-boxes/new-prod-boxes.css @@ -473,6 +473,7 @@ color: #1C7928; font-weight: bold; font-size: calc(14px + 2 * (100vw - 768px) / 680); + visibility: visible; } .new-prod-boxes-container.green-pill .block .prod_box .inner_prod_box .save_price_box .prod-percent { diff --git a/_src-lp/blocks/new-prod-boxes/new-prod-boxes.scss b/_src-lp/blocks/new-prod-boxes/new-prod-boxes.scss index cfe20339..31e2b5ef 100644 --- a/_src-lp/blocks/new-prod-boxes/new-prod-boxes.scss +++ b/_src-lp/blocks/new-prod-boxes/new-prod-boxes.scss @@ -518,6 +518,7 @@ color: #1C7928; font-weight: bold; font-size: calc(14px + 2 * ((100vw - 768px) / 680)); + visibility: visible; } .new-prod-boxes-container.green-pill .block .prod_box .inner_prod_box .save_price_box .prod-percent { From b709a65862961e64ee1067b45040f1c37a404877 Mon Sep 17 00:00:00 2001 From: ltiseanu Date: Mon, 3 Feb 2025 09:49:57 +0200 Subject: [PATCH 3/5] DEX-21657 - Update Brand Search LP --- .../blocks/new-prod-boxes/new-prod-boxes.css | 1 - .../blocks/new-prod-boxes/new-prod-boxes.js | 25 ++++++++++--------- .../blocks/new-prod-boxes/new-prod-boxes.scss | 1 - _src-lp/scripts/utils.js | 2 ++ 4 files changed, 15 insertions(+), 14 deletions(-) diff --git a/_src-lp/blocks/new-prod-boxes/new-prod-boxes.css b/_src-lp/blocks/new-prod-boxes/new-prod-boxes.css index 4aa87d38..3d7d334d 100644 --- a/_src-lp/blocks/new-prod-boxes/new-prod-boxes.css +++ b/_src-lp/blocks/new-prod-boxes/new-prod-boxes.css @@ -473,7 +473,6 @@ color: #1C7928; font-weight: bold; font-size: calc(14px + 2 * (100vw - 768px) / 680); - visibility: visible; } .new-prod-boxes-container.green-pill .block .prod_box .inner_prod_box .save_price_box .prod-percent { diff --git a/_src-lp/blocks/new-prod-boxes/new-prod-boxes.js b/_src-lp/blocks/new-prod-boxes/new-prod-boxes.js index 4ee4f661..88455079 100644 --- a/_src-lp/blocks/new-prod-boxes/new-prod-boxes.js +++ b/_src-lp/blocks/new-prod-boxes/new-prod-boxes.js @@ -301,18 +301,6 @@ export default function decorate(block) { } let percentOffFlag = false; - let percentOff = Array.from(saveOldPrice.querySelectorAll('td'))[1].innerText.replace('0%', ``); - if (!saveOldPrice.querySelectorAll('td')[1].innerText.includes('0%') && saveOldPrice.querySelectorAll('td')[1].innerText.includes('0')) { - percentOff = Array.from(saveOldPrice.querySelectorAll('td'))[1].innerText.replace('0', ``); - percentOffFlag = true; - } - if (!saveOldPrice.querySelectorAll('td')[1].innerText.includes('0%') && !saveOldPrice.querySelectorAll('td')[1].innerText.includes('0')) { - percentOff = saveOldPrice.querySelectorAll('td')[1].innerText; - percentOffFlag = true; - } - if (!percentOff) { - percentOffFlag = false; - } const optionList = subtitle.querySelector('ul'); const combinedPricesBox = document.createElement('div'); @@ -325,6 +313,19 @@ export default function decorate(block) { const value = variationText.trim(); const isChecked = idx === 0 ? 'checked' : ''; + let percentOff = Array.from(saveOldPrice.querySelectorAll('td'))[1].innerText.replace('0%', ``); + if (!saveOldPrice.querySelectorAll('td')[1].innerText.includes('0%') && saveOldPrice.querySelectorAll('td')[1].innerText.includes('0')) { + percentOff = Array.from(saveOldPrice.querySelectorAll('td'))[1].innerText.replace('0', ``); + percentOffFlag = true; + } + if (!saveOldPrice.querySelectorAll('td')[1].innerText.includes('0%') && !saveOldPrice.querySelectorAll('td')[1].innerText.includes('0')) { + percentOff = saveOldPrice.querySelectorAll('td')[1].innerText; + percentOffFlag = true; + } + if (!percentOff) { + percentOffFlag = false; + } + li.setAttribute('data-selector-u', `u_${selectorClass}`); li.setAttribute('data-value-u', pusers); li.setAttribute('data-selector-y', `y_${selectorClass}`); diff --git a/_src-lp/blocks/new-prod-boxes/new-prod-boxes.scss b/_src-lp/blocks/new-prod-boxes/new-prod-boxes.scss index 31e2b5ef..cfe20339 100644 --- a/_src-lp/blocks/new-prod-boxes/new-prod-boxes.scss +++ b/_src-lp/blocks/new-prod-boxes/new-prod-boxes.scss @@ -518,7 +518,6 @@ color: #1C7928; font-weight: bold; font-size: calc(14px + 2 * ((100vw - 768px) / 680)); - visibility: visible; } .new-prod-boxes-container.green-pill .block .prod_box .inner_prod_box .save_price_box .prod-percent { diff --git a/_src-lp/scripts/utils.js b/_src-lp/scripts/utils.js index 385d0f17..d323ed43 100644 --- a/_src-lp/scripts/utils.js +++ b/_src-lp/scripts/utils.js @@ -502,11 +502,13 @@ export async function showPrices(storeObj, triggerVPN = false, checkboxId = '', if (parentSaveBox) { parentSaveBox.innerHTML = savings; parentSaveBox.style.visibility = 'visible'; + parentSaveBox.closest('.save').style.visibility = 'visible'; } } else { document.querySelectorAll(`.save-${onSelectorClass}`).forEach((item) => { item.innerHTML = savings; item.style.visibility = 'visible'; + item.closest('.save').style.visibility = 'visible'; }); } } From 1c1bfeb23a08289f25b416110f23b8b848b9add4 Mon Sep 17 00:00:00 2001 From: ltiseanu Date: Mon, 3 Feb 2025 10:23:23 +0200 Subject: [PATCH 4/5] fix: 'percentOff' is not defined --- _src-lp/blocks/new-prod-boxes/new-prod-boxes.js | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/_src-lp/blocks/new-prod-boxes/new-prod-boxes.js b/_src-lp/blocks/new-prod-boxes/new-prod-boxes.js index 88455079..10121820 100644 --- a/_src-lp/blocks/new-prod-boxes/new-prod-boxes.js +++ b/_src-lp/blocks/new-prod-boxes/new-prod-boxes.js @@ -301,6 +301,18 @@ export default function decorate(block) { } let percentOffFlag = false; + let percentOff = Array.from(saveOldPrice.querySelectorAll('td'))[1].innerText.replace('0%', ``); + if (!saveOldPrice.querySelectorAll('td')[1].innerText.includes('0%') && saveOldPrice.querySelectorAll('td')[1].innerText.includes('0')) { + percentOff = Array.from(saveOldPrice.querySelectorAll('td'))[1].innerText.replace('0', ``); + percentOffFlag = true; + } + if (!saveOldPrice.querySelectorAll('td')[1].innerText.includes('0%') && !saveOldPrice.querySelectorAll('td')[1].innerText.includes('0')) { + percentOff = saveOldPrice.querySelectorAll('td')[1].innerText; + percentOffFlag = true; + } + if (!percentOff) { + percentOffFlag = false; + } const optionList = subtitle.querySelector('ul'); const combinedPricesBox = document.createElement('div'); @@ -313,7 +325,7 @@ export default function decorate(block) { const value = variationText.trim(); const isChecked = idx === 0 ? 'checked' : ''; - let percentOff = Array.from(saveOldPrice.querySelectorAll('td'))[1].innerText.replace('0%', ``); + percentOff = Array.from(saveOldPrice.querySelectorAll('td'))[1].innerText.replace('0%', ``); if (!saveOldPrice.querySelectorAll('td')[1].innerText.includes('0%') && saveOldPrice.querySelectorAll('td')[1].innerText.includes('0')) { percentOff = Array.from(saveOldPrice.querySelectorAll('td'))[1].innerText.replace('0', ``); percentOffFlag = true; From a9e3533b4390e6315ee054c398997205a330d8d2 Mon Sep 17 00:00:00 2001 From: ltiseanu Date: Mon, 3 Feb 2025 10:29:10 +0200 Subject: [PATCH 5/5] fix lint --- _src-lp/blocks/banner/banner.css | 8 ++++---- _src-lp/blocks/banner/banner.scss | 8 ++++---- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/_src-lp/blocks/banner/banner.css b/_src-lp/blocks/banner/banner.css index c66f7c71..da8fef4f 100644 --- a/_src-lp/blocks/banner/banner.css +++ b/_src-lp/blocks/banner/banner.css @@ -220,6 +220,10 @@ border-radius: 22px; } +.section.banner-container.new-2024.v2 p a { + text-decoration: underline; +} + .section.banner-container.hasslide .block table tr td a { color: white; } @@ -400,10 +404,6 @@ color: inherit; } -.section.banner-container.new-2024.v2 p a { - text-decoration: underline; -} - .section.banner-container.hasslide .block table tr td a:hover { text-decoration: none; opacity: 0.7; diff --git a/_src-lp/blocks/banner/banner.scss b/_src-lp/blocks/banner/banner.scss index 32ac3fc6..06b05db6 100644 --- a/_src-lp/blocks/banner/banner.scss +++ b/_src-lp/blocks/banner/banner.scss @@ -221,6 +221,10 @@ border-radius: 22px; } +.section.banner-container.new-2024.v2 p a { + text-decoration: underline; +} + .section.banner-container.hasslide .block table tr td a { color: white; } @@ -401,10 +405,6 @@ color: inherit; } -.section.banner-container.new-2024.v2 p a { - text-decoration: underline; -} - .section.banner-container.hasslide .block table tr td a:hover { text-decoration: none; opacity: 0.7;