Skip to content

Test excluded bounds in SpkTxOutIndex::outputs_in_range #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
notmandatory opened this issue Nov 13, 2024 · 1 comment · May be fixed by bitcoindevkit/bdk#1897
Open

Test excluded bounds in SpkTxOutIndex::outputs_in_range #58

notmandatory opened this issue Nov 13, 2024 · 1 comment · May be fixed by bitcoindevkit/bdk#1897
Labels
audit Suggested as result of external code audit tests New or improved tests

Comments

@notmandatory
Copy link
Member

notmandatory commented Nov 13, 2024 •
edited
Loading

"For SpkTxOutIndex::outputs_in_range() the excluded bounds aren't tested, you can just change them to whatever and no test would fail."
@notmandatory notmandatory converted this from a draft issue Nov 13, 2024
@notmandatory notmandatory added audit Suggested as result of external code audit tests New or improved tests labels Nov 13, 2024
@notmandatory notmandatory moved this to Todo in BDK Wallet Nov 13, 2024
@aagbotemi aagbotemi linked a pull request Mar 18, 2025 that will close this issue
Open
8 tasks
@aagbotemi
Copy link

Hi @notmandatory, I raised a PR for this issue here bitcoindevkit/bdk#1897. Kindly help me take a look at it.

@notmandatory notmandatory transferred this issue from bitcoindevkit/bdk Apr 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
audit Suggested as result of external code audit tests New or improved tests
Projects
BDK Wallet
Status: Todo
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test for excluded bounds in outputs_in_range aagbotemi/bdk
2 participants
@notmandatory @aagbotemi