-
Notifications
You must be signed in to change notification settings - Fork 23
bdk_electrum: cache merkle proofs #56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I'll probably take a stab at this as well and throw it onto bitcoindevkit/bdk#1675. |
I'll probably make a separate PR for this. The previous After discussion with Evan, our idea is that we should instead: |
c5f5284 upgrade bitcoin to 0.32 and related (Michael Mallan) Pull request description: This is to upgrade bitcoin to 0.32 and related dependencies accordingly. Note that the bdk_electrum crate has not been upgraded to the most recent version available as the Electrum syncing there takes much longer due to the fetching and validation of Merkle proofs. There are ongoing changes in relation to that (https://github.com/bitcoindevkit/bdk/issues/1699) and so we can further upgrade this dependency once those changes have been completed. Non-BDK changes to the liana and lianad crates are taken from commit 20ee8b1 in draft PR #1228, which this replaces. (Once this PR has been tested and approved, we can release a new version of the async_hwi crate and point to that.) ACKs for top commit: edouardparis: ACK c5f5284 Tree-SHA512: 3cb1a2060ecc4c6b9631df0eadf5692ad35495b9303edbb80a437aca60ae062a7227f20ddeb5eb722cf57dd80bfa752372a14d26b8f306844237bfdb5f41e51a
"You cache transactions but not their anchor's validity, which significantly reduces the gains from caching as you need to make a request for Merkle proofs anyways."
The text was updated successfully, but these errors were encountered: