-
Notifications
You must be signed in to change notification settings - Fork 23
Use srcipthash_subscribe
when syncing ElectrumBlockchain
#184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I don't get why that warning exists at all. The whole advantage of using electrum is stateless querying. |
Being able to subscribe instead of querying every scripthash every time would be very useful. Currently, to check the balance of the wallet, we have to query every scripthash. For wallets with a large transaction history this takes a very long time. If we could subscribe then it would massively speed up |
see also #141 |
Describe
Not a bug :) More a question:
We noticed that electrs is printing warnings in the log, e.g.
When digging deeper into the code base, we saw that this message is printed when trying to get the history for a scripthash,
i.e. this warning seems to be printed here:
https://github.com/romanz/electrs/blob/ca2841f43263db7f211f63c7448c1bc6e7a3f1c7/src/electrum.rs#L266-L282
Which seems to be coming from the sync/wallet_setup function of the electrum client here:
https://github.com/bitcoindevkit/bdk/blob/9c405e9c70e417dea0e610f9d44e99911d6b4e44/src/blockchain/electrum.rs#L123
This ticket on electrs is related: romanz/electrs#652
The question is, can we use the recommended functionality of
scripthash_subscribe
here instead?To Reproduce
ElectrumBlockchain
Build environment
The text was updated successfully, but these errors were encountered: