Merge #317: chore: bump MSRV to 1.85.0

eceb1a3 ci: Add .github/zizmor.yml config (valued mammal)
c78915a Update README example to use rusqlite (valued mammal)
b5db35e Make repo into a single crate (valued mammal)
a489e35 Update justfile (valued mammal)
70560b5 Rename `example-crates` directory (valued mammal)
f21e26e ci: Remove unmaintained actions-rs/toolchain (valued mammal)
9d0491c chore: bump MSRV to 1.85.0 (valued mammal)
dc13690 chore: exclude example crates (valued mammal)

Pull request description:

  Bump `bdk_wallet` MSRV to 1.85.0.

  Restructure repository to be a single rust project.

  Small cleanups to `.github/workflows` by moving away from unmaintained `actions-rs/toolchain` in favor of `dtolnay/rust-toolchain`.

  Follow-ups

  - [x] Address zizmor code scanning results
  - [ ] Use rust edition 2024. May have to remove some "unnecessary binding modifiers"
  - [ ] Consider updating `.github/CODEOWNERS`

  fix #289

  ### Notes to the reviewers

  ### Changelog notice

  ```md
  Changed

  - Raise project MSRV to 1.85.0
  - ci: Migrate to `dtolnay/rust-toolchain`
  - ci: Add zizmor.yml config
  ```

  ### Checklists

  #### All Submissions:

  * [x] I've signed all my commits
  * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md)

ACKs for top commit:
  thunderbiscuit:
    ACK eceb1a3. Nice cleanup.

Tree-SHA512: 57d155851b96dba12d534c8d9b1a91c147c0fe390f9931f0961b471518b6a7df1dd19c167b3e4d0c1187306af8f5ccb003bcf7dec0ef453e1cf4a9b172c5fb00

Author: ValuedMammal

.github/workflows/code_coverage.yml

@@ -21,11 +21,9 @@ jobs:
       - name: Install lcov tools
         run: sudo apt-get install lcov -y
       - name: Install Rust toolchain
-        uses: actions-rs/toolchain@v1
+        uses: dtolnay/rust-toolchain@v1
         with:
             toolchain: stable
-            override: true
-            profile: minimal
             components: llvm-tools-preview
       - name: Rust Cache
         uses: Swatinem/rust-cache@98c8021b550208e191a6a3145459bfc9fb29c4c0

.github/workflows/cont_integration.yml

@@ -4,8 +4,10 @@ name: CI
 
 permissions: {}
 
-jobs:
+env:
+  CARGO_TERM_COLOR: always
 
+jobs:
   prepare:
     runs-on: ubuntu-latest
     outputs:
@@ -30,8 +32,7 @@ jobs:
           - ubuntu-24.04-arm
         rust:
           - version: ${{ needs.prepare.outputs.rust_version }}
-            clippy: true
-          - version: 1.63.0 # Overall MSRV
+          - version: 1.85.0 # MSRV
         features:
           - --no-default-features --features miniscript/no-std,bdk_chain/hashbrown
           - --all-features
@@ -41,22 +42,20 @@ jobs:
         with:
           persist-credentials: false
       - name: Install Rust toolchain
-        uses: actions-rs/toolchain@v1
+        uses: dtolnay/rust-toolchain@v1
         with:
             toolchain: ${{ matrix.rust.version }}
-            override: true
-            profile: minimal
       - name: Rust Cache
         uses: Swatinem/rust-cache@98c8021b550208e191a6a3145459bfc9fb29c4c0
       - name: Pin dependencies for MSRV
-        if: matrix.rust.version == '1.63.0'
+        if: matrix.rust.version == '1.85.0'
         run: ./ci/pin-msrv.sh
       - name: Build + Test
         env:
           MATRIX_RUST_VERSION: ${{ matrix.rust.version }}
         run: |
-          cargo build --workspace --exclude 'example_*' ${{ matrix.features }}
-          cargo test --workspace --exclude 'example_*' ${{ matrix.features }}
+          cargo build --workspace --all-targets ${{ matrix.features }}
+          cargo test --workspace ${{ matrix.features }}
 
   check-no-std:
     needs: prepare
@@ -68,16 +67,13 @@ jobs:
         with:
           persist-credentials: false
       - name: Install Rust toolchain
-        uses: actions-rs/toolchain@v1
+        uses: dtolnay/rust-toolchain@v1
         with:
           toolchain: ${{ needs.prepare.outputs.rust_version }}
-          override: true
-          profile: minimal
           # target: "thumbv6m-none-eabi"
       - name: Rust Cache
         uses: Swatinem/rust-cache@98c8021b550208e191a6a3145459bfc9fb29c4c0
-      - name: Check bdk wallet
-        working-directory: ./wallet
+      - name: Check no-std
         # TODO "--target thumbv6m-none-eabi" should work but currently does not
         run: cargo check --no-default-features --features miniscript/no-std,bdk_chain/hashbrown
 
@@ -98,16 +94,13 @@ jobs:
       - run: sudo apt-get update || exit 1
       - run: sudo apt-get install -y libclang-common-14-dev clang-14 libc6-dev-i386 || exit 1
       - name: Install Rust toolchain
-        uses: actions-rs/toolchain@v1
+        uses: dtolnay/rust-toolchain@v1
         with:
             toolchain: ${{ needs.prepare.outputs.rust_version }}
-            override: true
-            profile: minimal
-            target: "wasm32-unknown-unknown"
+            targets: "wasm32-unknown-unknown"
       - name: Rust Cache
         uses: Swatinem/rust-cache@98c8021b550208e191a6a3145459bfc9fb29c4c0
-      - name: Check bdk wallet
-        working-directory: ./wallet
+      - name: Check WASM
         run: cargo check --target wasm32-unknown-unknown --no-default-features --features miniscript/no-std,bdk_chain/hashbrown
 
   fmt:
@@ -119,11 +112,9 @@ jobs:
         with:
           persist-credentials: false
       - name: Install Rust toolchain
-        uses: actions-rs/toolchain@v1
+        uses: dtolnay/rust-toolchain@v1
         with:
             toolchain: nightly
-            override: true
-            profile: minimal
             components: rustfmt
       - name: Check fmt
         run: cargo fmt --all --check
@@ -138,43 +129,12 @@ jobs:
       - uses: actions/checkout@v4
         with:
           persist-credentials: false
-      - uses: actions-rs/toolchain@v1
+      - uses: dtolnay/rust-toolchain@v1
         with:
             toolchain: ${{ needs.prepare.outputs.rust_version }}
             components: clippy
-            override: true
       - name: Rust Cache
         uses: Swatinem/rust-cache@98c8021b550208e191a6a3145459bfc9fb29c4c0
-      - uses: actions-rs/clippy-check@v1
-        with:
-          token: ${{ secrets.GITHUB_TOKEN }}
-          name: Clippy Results
-          args: --all-features --all-targets -- -D warnings
+      - name: Clippy
+        run: cargo clippy --all-features --all-targets -- -D warnings
 
-  build-examples:
-    needs: prepare
-    name: Build & Test Examples
-    runs-on: ubuntu-latest
-    strategy:
-      matrix:
-        example-dir:
-          - example_wallet_electrum
-          - example_wallet_esplora_async
-          - example_wallet_esplora_blocking
-          - example_wallet_rpc
-    steps:
-      - name: checkout
-        uses: actions/checkout@v4
-        with:
-          persist-credentials: false
-      - name: Install Rust toolchain
-        uses: actions-rs/toolchain@v1
-        with:
-          toolchain: ${{ needs.prepare.outputs.rust_version }}
-          override: true
-          profile: minimal
-      - name: Rust Cache
-        uses: Swatinem/rust-cache@98c8021b550208e191a6a3145459bfc9fb29c4c0
-      - name: Build
-        working-directory: examples/${{ matrix.example-dir }}
-        run: cargo build

.github/zizmor.yml

@@ -0,0 +1,7 @@
+# Zizmor config
+rules:
+  unpinned-uses:
+    config:
+      policies:
+        # Allow pin by ref/tag
+        dtolnay/rust-toolchain: ref-pin

.gitignore

@@ -8,3 +8,4 @@ Cargo.lock
 # Example persisted files.
 *.db
 *.sqlite*
+examples/test_data

wallet/CHANGELOG.md renamed to CHANGELOG.md

@@ -46,7 +46,7 @@ Every new feature should be covered by functional tests where possible.
 When refactoring, structure your PR to make it easy to review and don't
 hesitate to split it into multiple small, focused PRs.
 
-The Minimum Supported Rust Version is **1.63.0** (enforced by our CI).
+The Minimum Supported Rust Version is **1.85.0** (enforced by our CI).
 
 Commits should cover both the issue fixed and the solution's rationale.
 These [guidelines](https://chris.beams.io/posts/git-commit/) should be kept in mind. Commit messages follow the ["Conventional Commits 1.0.0"](https://www.conventionalcommits.org/en/v1.0.0/) to make commit histories easier to read by humans and automated tools. All commits must be [GPG signed](https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits).

CONTRIBUTING.md

@@ -1,16 +1,76 @@
-[workspace]
-resolver = "2"
-members = [
-    "wallet",
-    "examples/example_wallet_electrum",
-    "examples/example_wallet_esplora_blocking",
-    "examples/example_wallet_esplora_async",
-    "examples/example_wallet_rpc",
-]
-
-[workspace.package]
+[package]
+name = "bdk_wallet"
+homepage = "https://bitcoindevkit.org"
+version = "3.0.0-alpha.0"
+repository = "https://github.com/bitcoindevkit/bdk_wallet"
+documentation = "https://docs.rs/bdk_wallet"
+description = "A modern, lightweight, descriptor-based wallet library"
+keywords = ["bitcoin", "wallet", "descriptor", "psbt"]
+readme = "README.md"
+license = "MIT OR Apache-2.0"
 authors = ["Bitcoin Dev Kit Developers"]
+edition = "2021"
+rust-version = "1.85.0"
 
-[workspace.lints.clippy]
-print_stdout = "deny"
-print_stderr = "deny"
+[package.metadata.docs.rs]
+all-features = true
+rustdoc-args = ["--cfg", "docsrs"]
+
+[dependencies]
+bdk_chain = { version = "0.23.1", features = ["miniscript", "serde"], default-features = false }
+bitcoin = { version = "0.32.6", features = ["serde", "base64"], default-features = false }
+miniscript = { version = "12.3.1", features = ["serde"], default-features = false }
+rand_core = { version = "0.6.0" }
+serde_json = { version = "1" }
+serde = { version = "1", features = ["derive"] }
+
+# Optional dependencies
+anyhow = { version = "1.0.98", optional = true }
+bdk_file_store = { version = "0.21.1", optional = true }
+bip39 = { version = "2.0", optional = true }
+tempfile = { version = "3.20.0", optional = true }
+
+[features]
+default = ["std"]
+std = ["bitcoin/std", "bitcoin/rand-std", "miniscript/std", "bdk_chain/std"]
+compiler = ["miniscript/compiler"]
+all-keys = ["keys-bip39"]
+keys-bip39 = ["bip39"]
+rusqlite = ["bdk_chain/rusqlite"]
+file_store = ["bdk_file_store"]
+test-utils = ["std", "anyhow", "tempfile"]
+
+[dev-dependencies]
+anyhow = "1"
+assert_matches = "1.5.0"
+bdk_bitcoind_rpc = { version = "0.21.0" }
+bdk_electrum = { version = "0.23.1" }
+bdk_esplora = { version = "0.22.1", features = ["async-https", "blocking-https", "tokio"] }
+bdk_wallet = { path = ".", features = ["rusqlite", "file_store", "test-utils"] }
+clap = { version = "4.5.17", features = ["derive", "env"] }
+ctrlc = "3.4.6"
+rand = "0.8"
+tempfile = "3"
+tokio = { version = "1.38.1", features = ["rt", "rt-multi-thread", "macros"] }
+
+[[example]]
+name = "mnemonic_to_descriptors"
+path = "examples/mnemonic_to_descriptors.rs"
+required-features = ["all-keys"]
+
+[[example]]
+name = "miniscriptc"
+path = "examples/compiler.rs"
+required-features = ["compiler"]
+
+[[example]]
+name = "electrum"
+
+[[example]]
+name = "esplora_async"
+
+[[example]]
+name = "esplora_blocking"
+
+[[example]]
+name = "bitcoind_rpc"