Skip to content

Conversation

@ValuedMammal
Copy link
Collaborator

@ValuedMammal ValuedMammal commented Nov 6, 2025

Description

PR pins home dependency in CI to 0.5.11 in order to build on rust 1.85.0.

Checklists

All Submissions:

@ValuedMammal ValuedMammal self-assigned this Nov 6, 2025
@ValuedMammal ValuedMammal added the dependencies Pull requests that update a dependency file label Nov 6, 2025
@ValuedMammal ValuedMammal moved this to Needs Review in BDK Chain Nov 6, 2025
@ValuedMammal ValuedMammal added this to the Chain 0.24.0 milestone Nov 6, 2025
Copy link
Contributor

@tnull tnull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of pinning home (which is just a sub-dependency of electrsd through which) you should be able to rather bump electrsd to 0.36.1 that includes RCasatta/electrsd#114, simply dropping the unnecessary dependency altogether.

@tnull
Copy link
Contributor

tnull commented Nov 7, 2025

Instead of pinning home (which is just a sub-dependency of electrsd through which) you should be able to rather bump electrsd to 0.36.1 that includes RCasatta/electrsd#114, simply dropping the unnecessary dependency altogether.

Ah, nvm, I realize you haven't made the switch to corepc-node yet. Would be the 'real' fix here though.

Copy link
Member

@evanlinjin evanlinjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 93155d2

@evanlinjin evanlinjin merged commit d2271ea into bitcoindevkit:master Nov 9, 2025
17 checks passed
@github-project-automation github-project-automation bot moved this from Needs Review to Done in BDK Chain Nov 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants