Skip to content

Add the KeychainKind to the AddressInfo struct #541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
notmandatory opened this issue Feb 11, 2022 · 4 comments · Fixed by #563
Closed

Add the KeychainKind to the AddressInfo struct #541

notmandatory opened this issue Feb 11, 2022 · 4 comments · Fixed by #563
Assignees
@Eunoia1729 @ricknjacky
Labels
good first issue Good for newcomers new feature New feature or request
Milestone
Release 0.18.0 Fe...

Comments

@notmandatory
Copy link
Member

Add the KeychainKind field to the AddressInfo struct and update any functions that return AddressInfo to set it.

See discussion in #528
@notmandatory notmandatory added new feature New feature or request good first issue Good for newcomers labels Feb 11, 2022
@ricknjacky
Copy link

@notmandatory I'd like to work on this issue.

I'm new to this project and I just started learning rust to contribute here. I hope this will be a good starting point for contributing.

Can I take this up ? I'll also be glad to get a heads up of sorts.
Thanks.

@notmandatory
Copy link
Member Author

Hi @ricknjacky welcome! yes I'll put your name on this one. Leave a comment here or we can discuss on discord if you need help or have any questions.

@Eunoia1729
Copy link
Contributor

Eunoia1729 commented Mar 7, 2022 •
edited
Loading

@ricknjacky With your permission, can I take this forward ?
I've made the updates and only, making a PR is remaining.

Thanks in advance !

Edit: I've opened a PR so we can collaborate better.

@Eunoia1729 Eunoia1729 mentioned this issue Mar 10, 2022
Merged
3 tasks
@notmandatory
Copy link
Member Author

@ricknjacky if you're still interested in working on this issue please help test and review @Eunoia1729's PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Eunoia1729 Eunoia1729

@ricknjacky ricknjacky

Labels
good first issue Good for newcomers new feature New feature or request
Projects
None yet
Milestone
Release 0.18.0 Feature Freeze
Development

Successfully merging a pull request may close this issue.

update AddressInfo struct Eunoia1729/bdk
3 participants
@notmandatory @Eunoia1729 @ricknjacky