Skip to content

Commit b8746c8

Browse files
committed
Merge #1636: ci: fix build-test job with --no-default-features, add miniscript/no-std
0e80824 ci: fix build-test job with --no-default-features, add miniscript/no-std (Steve Myers) Pull request description: ### Description Fixes the CI `build-test` job with `--no-default-features` by also adding `--features miniscript/no-std`. Until `rust-miniscript` removes the `no-std` feature we need to enable it when `--no-default-features` is used to build `bdk_wallet` or the whole workspace. See also the `check-no-std` job which does the same plus enables the `bdk_chain/hashbrown` feature which is also needed to build `bdk_wallet` with `--no-default-features` but is already enabled when building the whole workspace. ### Notes to the reviewers I think we didn't catch this on #1625 because the CI job names changed and I didn't update the branch merge requirements. Another possibility is it was passing because of cached build artifacts which I removed last night when I was trying to troubleshoot something else. I've updated the required CI jobs that need to pass before allowing a PR to be merged to `master` to include the ones with `--no-default-features --features bdk_chain/hashbrown` in the name. ### Checklists #### All Submissions: * [x] I've signed all my commits * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md) * [ ] I ran `cargo fmt` and `cargo clippy` before committing ACKs for top commit: ValuedMammal: ACK 0e80824 Tree-SHA512: 5da486b7fd988575b6f9c06eb108a183b47c74d58fd451453d77b53ad26f58890ee605f4a154922688dc348bc5a3c413dcd9128fd4831d8923c64a33aa4a951c
2 parents 139d971 + 0e80824 commit b8746c8

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

.github/workflows/cont_integration.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ jobs:
2525
clippy: true
2626
- version: 1.63.0 # MSRV
2727
features:
28-
- --no-default-features
28+
- --no-default-features --features miniscript/no-std
2929
- --all-features
3030
steps:
3131
- name: checkout

0 commit comments

Comments
 (0)