Skip to content

Upgrade for bdk v0.17.0 #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rajarshimaitra opened this issue Mar 25, 2022 · 4 comments · Fixed by #73
Closed

Upgrade for bdk v0.17.0 #81

rajarshimaitra opened this issue Mar 25, 2022 · 4 comments · Fixed by #73
Assignees
Labels
enhancement New feature or request question Further information is requested
Milestone

Comments

@rajarshimaitra
Copy link
Contributor

rajarshimaitra commented Mar 25, 2022

In light of bitcoindevkit/bdk#535, I feel the cli code can be optimized a lot. We can remove the OnlineWalletSubcommand and OfflineWalletSubcommand, as there is now no distinction between online and offline wallets. All wallets are offline and we only need a blockchian when we want to sync and broadcast..

This needs to be done before other open PRs can be merged or else it might cause rework on them.

So opening up this issue for approach discussion. Whats the best way structure bdk-cli after the big bdk change? Or should the same structure be kept as it is and adopt with minimal changes?

@rajarshimaitra rajarshimaitra self-assigned this Mar 25, 2022
@rajarshimaitra rajarshimaitra added enhancement New feature or request question Further information is requested labels Mar 25, 2022
@rajarshimaitra rajarshimaitra linked a pull request Mar 25, 2022 that will close this issue
6 tasks
@notmandatory
Copy link
Member

I think the basic options and commands will look the same since we already only enable online commands when a blockchain feature is turned on. But I agree this is a high priority to update to the new bdk API.

@kirillzh
Copy link

kirillzh commented Mar 29, 2022

Could we also add verify feature? Getting this error right now when trying to install bdk-cli binary:

$ cargo install bdk-cli --features repl,electrum,compiler,verify

Package `bdk-cli v0.4.0` does not have the feature `verify` 

@notmandatory notmandatory added this to the Release 0.5.x milestone Mar 29, 2022
@notmandatory notmandatory mentioned this issue Mar 30, 2022
6 tasks
@rajarshimaitra
Copy link
Contributor Author

Could we also add verify feature? Getting this error right now when trying to install bdk-cli binary:

Yes currently bdk-cli doesn't expose the verify function. Do you think that is useful? I am curious to know your use case for transaction verification. In general if your wallet is connected to a backend node, the node verifies the transaction by itself and then provides it to the wallet.

@rajarshimaitra rajarshimaitra moved this from Todo to Ready to Review in BDK-CLI Roadmap Mar 31, 2022
@notmandatory
Copy link
Member

I've added a bdk-cli verify feature in #73

Repository owner moved this from Ready to Review to Done in BDK-CLI Roadmap Apr 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants