-
Notifications
You must be signed in to change notification settings - Fork 75
Upgrade for bdk v0.17.0 #81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I think the basic options and commands will look the same since we already only enable online commands when a blockchain feature is turned on. But I agree this is a high priority to update to the new bdk API. |
Could we also add
|
Yes currently bdk-cli doesn't expose the |
I've added a |
In light of bitcoindevkit/bdk#535, I feel the cli code can be optimized a lot. We can remove the
OnlineWalletSubcommand
andOfflineWalletSubcommand
, as there is now no distinction between online and offline wallets. All wallets are offline and we only need ablockchian
when we want to sync and broadcast..This needs to be done before other open PRs can be merged or else it might cause rework on them.
So opening up this issue for approach discussion. Whats the best way structure bdk-cli after the big bdk change? Or should the same structure be kept as it is and adopt with minimal changes?
The text was updated successfully, but these errors were encountered: