You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Merge #174: feature: update bdk-cli to use bdk_wallet v1
e0bd147 fix: clippy errors (Steve Myers)
524562c fix: signing / finalizing `psbt` (Vihiga Tyonum)
fb7232f rpc: print status during full_scan and sync (Steve Myers)
4a66557 ci: remove WASM job, fix more clippy errors (Steve Myers)
eb947fc ci: with msrv 1.75 pin minreq to 2.13.2 (Steve Myers)
efc5fc5 ci: fix clippy errors (Steve Myers)
92cabb1 ci: update actions checkout and cache to v4, simplify matrix features (Steve Myers)
cb10873 refactor: fix error handling (Vihiga Tyonum)
8307db0 feat: re-enable `rpc` feature (Vihiga Tyonum)
8ac2529 ci: update the CI workflow (Vihiga Tyonum)
a2ad6b3 feat: add ci test for features (Vihiga Tyonum)
50a6a60 refactor: remove rpc, cbf, cleanup features (Steve Myers)
0be8453 refactor: update onlinewalletsubcommands (Vihiga Tyonum)
440bd36 refactor: update creating_backend fn (Vihiga Tyonum)
58f07a1 refactor: update nodes.rs file (Vihiga Tyonum)
cb4450b refactor: update imports and reserves feature (Vihiga Tyonum)
50233dd refactor: replace bdk::error with custom error (Vihiga Tyonum)
b8d2357 feat: add custom error enum (Vihiga Tyonum)
6f263bf feat!: replace bdk with bdk_wallet & update deps (Vihiga Tyonum)
b56c023 refactor: update imports from bdk to bd_wallet (Vihiga Tyonum)
91f5918 refactor: update imports from bdk to bdk_wallet (Vihiga Tyonum)
ddce50d refactor: update imports from bdk to bdk_wallet (Vihiga Tyonum)
4c89cbf refactor:update imports from bdk to use bdk_wallet (Vihiga Tyonum)
890cb45 refactor: add bdk_wallet (Vihiga Tyonum)
Pull request description:
<!-- You can erase any parts of this template not applicable to your Pull Request. -->
### Description
<!-- Describe the purpose of this PR, what's being adding and/or fixed -->
This PR update `bdk-cli` to use `bdk_wallet` v1
Issue: #172 (comment)
### Notes to the reviewers
- replaced `list_transactions` with `transactions`
- set `enable_rbf` to be `true` by default
- update creating and serializing Psbts
- update `new_wallet` to return `PersistedWallet<Connection>`
- default fee_rate to use FeeRate::BROADCAST_MIN
- update `zeroize` to version `1.8.1` from `<1.4.0`
- update `bdk-reserves` from `0.27.1` to `0.29.0`
- replace `bdk/electrum` with `bdk_electrum` for the `electrum` feature
- add `bdk_esplora` for the `bdk/use-esplora-ureq` and `bdk/use-esplora-reqwest` features
- add `bdk_bitcoind_rpc` lib to replace `bdk/rpc` feature
- add `hwi` library to replace `bdk/hardware-signer` feature
<!-- In this section you can include notes directed to the reviewers, like explaining why some parts
of the PR were done in a specific way -->
## Changelog notice
- set `enable_rbf` to be `true` by default
- update using `PartiallySignedTransaction` to `Psbt`
- default fee_rate to use FeeRate::BROADCAST_MIN
- update `zeroize` to version `1.8.1` from `<1.4.0`
- update `bdk-reserves` from `0.27.1` to `0.29.0`
- replace `bdk/electrum` with `bdk_electrum` for the `electrum` feature
- replace `bdk/use-esplora-ureq` and `bdk/use-esplora-reqwest` with `bdk_esplora` lib
- replace `bdk/rpc` with `bdk_bitcoind_rpc` lib
- replace `bdk/hardware-signer` with `hwi` lib
<!-- Notice the release manager should include in the release tag message changelog -->
<!-- See https://keepachangelog.com/en/1.0.0/ for examples -->
### Checklists
#### All Submissions:
* [x] I've signed all my commits
* [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk-cli/blob/master/CONTRIBUTING.md)
* [x] I ran `cargo fmt` and `cargo clippy` before committing
#### Bugfixes:
* [x] This pull request breaks the existing API
* [x] I'm linking the issue being fixed by this PR
ACKs for top commit:
notmandatory:
ACK e0bd147
Tree-SHA512: cd548805327b55a66be26aa0402ef7a4512a0a75ffdcefa243c86d838d82215a5e4605989436903c135c31902e84cebf8d88197db18df9193d1fc0cb9e0f567f
0 commit comments