Wrong dialog icon for "Wallet to be encrypted"

[jonasschnelli]

The used icon in the "Wallet to be encrypted" is rather one used for "errors":

Ideally there is a non-red icon so people aren't thinking something went wrong.

[jonasschnelli]

On the other hand, we might want to use a warning icon to make people actual read the content... so unsure if we should fix this.

[maflcko]

I'd say this was intentional

[hebasto]

Hmm, I've got a yellow triangle:

... and the QMessageBox::warning is used:

gui/src/qt/askpassphrasedialog.cpp

Lines 130 to 133 in 49984b4

	QMessageBox::warning(this, tr("Wallet to be encrypted"),
	"<qt>" +
	tr("Your wallet is about to be encrypted. ") + encryption_reminder +
	"</b></qt>");

[jarolrod]

The red circle is the default icon for QMessageBox::critical, which would make this an interesting quirk. Also, it's entirely possible that what is shown is a QMessageBox::warning with the wrong icon being passed because of your systems GTK cache files. Certain GTK themes can influence what icon actually comes up as Qt >5.7 implemented a feature that uses the system's GTK cache files to load some icons. For example, I can get this white error symbol to come up:

To stay consistent, we could just provide our own custom icon via:
QMessageBoxName.setIcon(QMessageBox::setIconPixmap(arg))

[hebasto]

@jarolrod

... as Qt >5.7 implemented a feature that uses the system's GTK cache files to load some icons.

Could elaborate?