Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update theme files to minimize opening/closing php #1

Closed
billerickson opened this issue Apr 27, 2016 · 1 comment
Closed

Update theme files to minimize opening/closing php #1

billerickson opened this issue Apr 27, 2016 · 1 comment

Comments

@billerickson
Copy link
Owner

For instance, change footer.php from this:

<?php
/**
 * EA Starter
 *
 * @package      EAStarter
 * @since        1.0.0
 * @copyright    Copyright (c) 2014, Contributors to EA Genesis Child project
 * @license      GPL-2.0+
 */

?>
    <?php ea_structural_wrap( 'site-inner', 'close' ); ?>
    </div>

    <?php tha_footer_before(); ?>   
    <footer class="site-footer" role="contentinfo">
        <?php ea_structural_wrap( 'footer' ); ?>
        <?php tha_footer_top(); ?>

        <?php tha_footer_bottom(); ?>
        <?php ea_structural_wrap( 'footer', 'close' ); ?>
    </footer>
    <?php tha_footer_after(); ?>
</div>

<?php tha_body_bottom(); ?>
<?php wp_footer(); ?>

</body>
</html>

To this:

<?php
/**
 * EA Starter
 *
 * @package      EAStarter
 * @since        1.0.0
 * @copyright    Copyright (c) 2014, Contributors to EA Genesis Child project
 * @license      GPL-2.0+
 */

    ea_structural_wrap( 'site-inner', 'close' );
    echo '</div>';

    tha_footer_before();
    echo '<footer class="site-footer" role="contentinfo">';
        ea_structural_wrap( 'footer' );
        tha_footer_top();

        tha_footer_bottom();
        ea_structural_wrap( 'footer', 'close' );
    echo '</footer>';
    tha_footer_after();

    echo '</div>';

    tha_body_bottom();
    wp_footer();

    echo '</body>';
    echo '</html>';

@billerickson
Copy link
Owner Author

@jaredatch take a look at issue/1 and let me know what you think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant