Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable rounding and processing of writing of doubles to be optional #41

Open
michael-okeefe opened this issue Apr 19, 2024 · 0 comments
Assignees
Labels
performance A task related to assessing/enhancing performance
Milestone

Comments

@michael-okeefe
Copy link
Member

Pre-Conditions

In #34 we have confirmed that allowing a double to be written directly to string WITHOUT rounding or further processing is significantly faster than the current DoubleToString methodologies.

Problem

Writing of double values with processing for rounding and cleanup for dropping zeros is slow.

Proposed Solution

We desire to keep the current behavior for generating "presentation-quality" files but we want to enable a "speed-write" mode that tries to write out as quickly as possible. As such, we should add a new flag to the erin run subcommand (e.g., --speed-write) that will disable all rounding and text processing and just write raw doubles (and other data) as quickly as possible to the CSV output files.

@michael-okeefe michael-okeefe added the performance A task related to assessing/enhancing performance label Apr 19, 2024
@michael-okeefe michael-okeefe added this to the 2024-05 milestone Apr 19, 2024
@spahrenk spahrenk self-assigned this Apr 24, 2024
@michael-okeefe michael-okeefe modified the milestones: 2024 (Year End), 2025+ Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance A task related to assessing/enhancing performance
Projects
None yet
Development

No branches or pull requests

2 participants