Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installation is not implemented. #24

Open
andriish opened this issue Jan 6, 2023 · 4 comments · May be fixed by #25
Open

Installation is not implemented. #24

andriish opened this issue Jan 6, 2023 · 4 comments · May be fixed by #25

Comments

@andriish
Copy link

andriish commented Jan 6, 2023

Hi all, @nealkruis , @ptsullivan, @chipbarnaby, @galanCA,

I see that the installation is not implemented. Could you, please, do that?

I can make a MR by myself, but I'm kind of "third party".

Best regards,

Andrii

@nealkruis
Copy link
Member

@andriish what kind of installation are you looking for? As a library, Btwxt is generally compiled and linked to another program when that program is built.

We can set up to add platform specific binaries to each release on GitHub, but we can also set up the installation rules in CMake and use CPack to create installers to put the libraries somewhere else on your machine (like a common lib directory). I'm not sure how useful either of these would be.

I think it would help if I knew a bit more about how you want to use Btwxt.

@andriish
Copy link
Author

andriish commented Jan 6, 2023

Hi @nealkruis ,

thank you for your quick reply.

we can also set up the installation rules in CMake

This would be more than enough.

The use case is that I try to help a colleague to use btwtx in a larger cmake-based project and it is convenient to use btwtx there via ExternalProject_Add, but the install implementation is missing. One needs the lib and the headers.

Best regards,

Andrii

@nealkruis
Copy link
Member

nealkruis commented Jan 6, 2023

Thanks for the clarification!

We are planning a major release soon that might involve some refactoring of how the header files are situated. We can likely add this feature around the same time.

In the interim, I believe there are ways to use ExternalProject_Add without needing the install step. Can't you just add it as a git repository inside your source tree and add_subdirectory(path/to/btwxt)? This should build Btwxt and you can directly link its targets to your larger project.

@andriish andriish linked a pull request Jan 7, 2023 that will close this issue
@andriish
Copy link
Author

andriish commented Jan 7, 2023

Hi @nealkruis,

please have a look at #25 .

In the interim, I believe there are ways to use ExternalProject_Add without needing the install step.

Yes, basically substituting the installation with a manual copying.

Andrii

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants