From b75229dfdafb3416ff0dd01b5840a18b7a1ea0b1 Mon Sep 17 00:00:00 2001
From: teoxoy <28601907+teoxoy@users.noreply.github.com>
Date: Fri, 20 May 2022 23:29:43 +0200
Subject: [PATCH 1/2] use `BufferUsages::UNIFORM` instead of the implicit
 `BufferUsages::all()` due to the Default derive

---
 crates/bevy_pbr/src/render/mesh.rs | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/crates/bevy_pbr/src/render/mesh.rs b/crates/bevy_pbr/src/render/mesh.rs
index 1329d16ced9ab..befc255daf1c3 100644
--- a/crates/bevy_pbr/src/render/mesh.rs
+++ b/crates/bevy_pbr/src/render/mesh.rs
@@ -715,11 +715,18 @@ pub fn queue_mesh_bind_group(
 // ignoring the rest, whether they're valid for other dynamic offsets or not. This trick may
 // be supported later in encase, and then we should make use of it.
 
-#[derive(Default)]
 pub struct SkinnedMeshUniform {
     pub buffer: BufferVec<Mat4>,
 }
 
+impl Default for SkinnedMeshUniform {
+    fn default() -> Self {
+        Self {
+            buffer: BufferVec::new(BufferUsages::UNIFORM),
+        }
+    }
+}
+
 pub fn prepare_skinned_meshes(
     render_device: Res<RenderDevice>,
     render_queue: Res<RenderQueue>,

From 5b84e89d05bd867c5f6e88e4c88dda3c4a430157 Mon Sep 17 00:00:00 2001
From: teoxoy <28601907+teoxoy@users.noreply.github.com>
Date: Fri, 20 May 2022 23:36:45 +0200
Subject: [PATCH 2/2] remove Default BufferVec impl and make new const

---
 .../bevy_render/src/render_resource/buffer_vec.rs   | 13 ++-----------
 1 file changed, 2 insertions(+), 11 deletions(-)

diff --git a/crates/bevy_render/src/render_resource/buffer_vec.rs b/crates/bevy_render/src/render_resource/buffer_vec.rs
index ad8f5ff2adfe1..6e2deb3009018 100644
--- a/crates/bevy_render/src/render_resource/buffer_vec.rs
+++ b/crates/bevy_render/src/render_resource/buffer_vec.rs
@@ -14,23 +14,14 @@ pub struct BufferVec<T: Pod> {
     buffer_usage: BufferUsages,
 }
 
-impl<T: Pod> Default for BufferVec<T> {
-    fn default() -> Self {
+impl<T: Pod> BufferVec<T> {
+    pub const fn new(buffer_usage: BufferUsages) -> Self {
         Self {
             values: Vec::new(),
             buffer: None,
             capacity: 0,
-            buffer_usage: BufferUsages::all(),
             item_size: std::mem::size_of::<T>(),
-        }
-    }
-}
-
-impl<T: Pod> BufferVec<T> {
-    pub fn new(buffer_usage: BufferUsages) -> Self {
-        Self {
             buffer_usage,
-            ..Default::default()
         }
     }