Skip to content

Naga not compiling and causing build to fail. #2113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bentheperson1 opened this issue May 5, 2021 · 7 comments
Closed

Naga not compiling and causing build to fail. #2113

bentheperson1 opened this issue May 5, 2021 · 7 comments
Labels
A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior C-Dependencies A change to the crates that Bevy depends on P-High This is particularly urgent, and deserves immediate attention S-Blocked This cannot move forward until something else changes

Comments

@bentheperson1
Copy link

Bevy version

0.5.0

Operating system & version

Windows 10

What you did

I tried to run 'cargo run' but the build failed saying that a crate called naga couldn't be compiled.

What you expected to happen

It should've just compiled and ran normally.

What actually happened

The build failed and spat out a bunch of errors.

Additional information

Screenshot 2021-05-05 160751
@bentheperson1 bentheperson1 added C-Bug An unexpected or incorrect behavior S-Needs-Triage This issue needs to be labelled labels May 5, 2021
@alice-i-cecile
Copy link
Member

spirv_headers published an update that broke semver today :( We're working on getting this fixed ASAP.

@alice-i-cecile alice-i-cecile added S-Blocked This cannot move forward until something else changes A-Rendering Drawing game state to the screen C-Dependencies A change to the crates that Bevy depends on and removed S-Needs-Triage This issue needs to be labelled labels May 5, 2021
@alice-i-cecile
Copy link
Member

alice-i-cecile commented May 5, 2021 •
edited
Loading

Relevant documentation on their end: https://github.com/gfx-rs/rspirv/blob/4419db432d90cd333e62aae9669dd263acff0499/MAINTENANCE.md; they don't follow semver. Looks like we may need to fix this with Bevy 0.5.1?

@mockersf
Copy link
Member

mockersf commented May 5, 2021

gfx-rs/naga#836

@MinerSebas
Copy link
Contributor

You can fix your local build by opening the Cargo.lock file, go to the spirv_headers entry, edit the version from 1.5.1 back to 1.5.0 and delete the checksum of spirv_headers.

@alice-i-cecile alice-i-cecile added the P-High This is particularly urgent, and deserves immediate attention label May 5, 2021
@Jasper-Bekkers
Copy link

Jasper-Bekkers commented May 5, 2021 •
edited
Loading

I've yanked 1.5.1 and we've started work on switching the spirv_headers crate to follow SemVer instead. For more information see the discussion in gfx-rs/rspirv#197 (not following SemVer has haunted the project for a long time)

@mockersf
Copy link
Member

mockersf commented May 5, 2021

thanks!

@alice-i-cecile
Copy link
Member

Closing as resolved <3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior C-Dependencies A change to the crates that Bevy depends on P-High This is particularly urgent, and deserves immediate attention S-Blocked This cannot move forward until something else changes
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@Jasper-Bekkers @alice-i-cecile @mockersf @bentheperson1 @MinerSebas