Skip to content

Yoink assert_object_safe #17531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
BenjaminBrienen opened this issue Jan 25, 2025 · 3 comments
Closed

Yoink assert_object_safe #17531

BenjaminBrienen opened this issue Jan 25, 2025 · 3 comments
Labels
A-Cross-Cutting Impacts the entire engine C-Code-Quality A section of code that is hard to understand or change D-Trivial Nice and easy! A great choice to get started with Bevy S-Ready-For-Implementation This issue is ready for an implementation PR. Go for it!

Comments

@BenjaminBrienen
Copy link
Contributor

BenjaminBrienen commented Jan 25, 2025 •
edited
Loading

we can just

/// Assert Trait is dyn compatible
const _: Option<Box<dyn Trait>> = None;

Originally posted by @mintlu8 in #11478 (comment)
@BenjaminBrienen BenjaminBrienen added A-Cross-Cutting Impacts the entire engine C-Code-Quality A section of code that is hard to understand or change D-Trivial Nice and easy! A great choice to get started with Bevy S-Ready-For-Implementation This issue is ready for an implementation PR. Go for it! labels Jan 25, 2025
@NyxAlexandra
Copy link
Contributor

we can just

/// Assert Trait is dyn compatible
const _: Option<Box<dyn Trait>> = None;

Originally posted by @mintlu8 in #11478 (comment)

Or Option<&dyn Trait>

@andristarr
Copy link
Contributor

I guess this issue is obsolete?

@cart
Copy link
Member

cart commented Mar 11, 2025

Yup!

@cart cart closed this as completed Mar 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Cross-Cutting Impacts the entire engine C-Code-Quality A section of code that is hard to understand or change D-Trivial Nice and easy! A great choice to get started with Bevy S-Ready-For-Implementation This issue is ready for an implementation PR. Go for it!
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@cart @andristarr @BenjaminBrienen @NyxAlexandra